Fix #1058

Author: cowtowncoder

release-notes/VERSION

@@ -7,6 +7,8 @@ Versions: 3.x (for earlier see VERSION-2.x)
 
 3.0.0 (not yet released)
 
+#1058: Add a way to pass std and format-specific parser/generator flags during
+  parser/generation construction
 #1762: `StdDateFormat`: serialize time offset using colon
 #1772: Remove `MapperFeature. USE_STD_BEAN_NAMING`
 #1773: Remove `MapperFeature.AUTO_DETECT_xxx` features

src/main/java/com/fasterxml/jackson/databind/node/ArrayNode.java

@@ -232,27 +232,52 @@ public List<JsonNode> findParents(String fieldName, List<JsonNode> foundSoFar)
      */
 
     /**
-     * Method that will set specified field, replacing old value,
-     * if any.
+     * Method that will set specified element, replacing old value.
      *
-     * @param value to set field to; if null, will be converted
+     * @param value to set element to; if null, will be converted
      *   to a {@link NullNode} first  (to remove field entry, call
      *   {@link #remove} instead)
      *
-     * @return Old value of the field, if any; null if there was no
-     *   old value.
+     * @return This node after adding/replacing property value (to allow chaining)
+     *
+     * @throws IndexOutOfBoundsException If Array does not have specified element
+     *  (that is, index is outside valid range of elements in array)
      */
-    public JsonNode set(int index, JsonNode value)
+    public ArrayNode set(int index, JsonNode value)
     {
         if (value == null) { // let's not store 'raw' nulls but nodes
             value = nullNode();
         }
         if (index < 0 || index >= _children.size()) {
             throw new IndexOutOfBoundsException("Illegal index "+ index +", array size "+size());
         }
-        return _children.set(index, value);
+        _children.set(index, value);
+        return this;
     }
 
+    /**
+     * Method that will set specified element, replacing old value.
+     *
+     * @param value to set element to; if null, will be converted
+     *   to a {@link NullNode} first  (to remove field entry, call
+     *   {@link #remove} instead)
+     *
+     * @return Old value of the element, if any; null if no such element existed.
+     *
+     * @throws IndexOutOfBoundsException If Array does not have specified element
+     *  (that is, index is outside valid range of elements in array)
+     */
+    public JsonNode replace(int index, JsonNode value)
+    {
+        if (value == null) { // let's not store 'raw' nulls but nodes
+            value = nullNode();
+        }
+        if (index < 0 || index >= _children.size()) {
+            throw new IndexOutOfBoundsException("Illegal index "+ index +", array size "+size());
+        }
+        return _children.set(index, value);
+    }
+    
     /**
      * Method for adding specified node at the end of this array.
      *
@@ -390,8 +415,6 @@ public ArrayNode addPOJO(Object value)
 
     /**
      * @return This array node, to allow chaining
-     *
-     * @since 2.6
      */
     public ArrayNode addRawValue(RawValue raw) {
         if (raw == null) {
@@ -516,8 +539,6 @@ public ArrayNode add(BigDecimal v) {
      * Method for adding specified number at the end of this array.
      *
      * @return This array node, to allow chaining
-     *
-     * @since 2.9
      */
     public ArrayNode add(BigInteger v) {
         if (v == null) {

src/main/java/com/fasterxml/jackson/databind/node/ObjectNode.java

@@ -334,7 +334,7 @@ public void serializeWithType(JsonGenerator g, SerializerProvider provider,
 
     /*
     /**********************************************************
-    /* Extended ObjectNode API, mutators, since 2.1
+    /* Extended ObjectNode API, mutators
     /**********************************************************
      */
 
@@ -348,10 +348,8 @@ public void serializeWithType(JsonGenerator g, SerializerProvider provider,
      *   {@link #remove} instead)
      *
      * @return This node after adding/replacing property value (to allow chaining)
-     *
-     * @since 2.1
      */
-    public JsonNode set(String fieldName, JsonNode value)
+    public ObjectNode set(String fieldName, JsonNode value)
     {
         if (value == null) {
             value = nullNode();
@@ -367,10 +365,8 @@ public JsonNode set(String fieldName, JsonNode value)
      * @param properties Properties to add
      * 
      * @return This node after adding/replacing property values (to allow chaining)
-     *
-     * @since 2.1
      */
-    public JsonNode setAll(Map<String,? extends JsonNode> properties)
+    public ObjectNode setAll(Map<String,? extends JsonNode> properties)
     {
         for (Map.Entry<String,? extends JsonNode> en : properties.entrySet()) {
             JsonNode n = en.getValue();
@@ -389,10 +385,8 @@ public JsonNode setAll(Map<String,? extends JsonNode> properties)
      * @param other Object of which properties to add to this object
      *
      * @return This node after addition (to allow chaining)
-     *
-     * @since 2.1
      */
-    public JsonNode setAll(ObjectNode other)
+    public ObjectNode setAll(ObjectNode other)
     {
         _children.putAll(other._children);
         return this;
@@ -407,8 +401,6 @@ public JsonNode setAll(ObjectNode other)
      * 
      * @return Old value of the property; null if there was no such property
      *   with value
-     * 
-     * @since 2.1
      */
     public JsonNode replace(String fieldName, JsonNode value)
     {
@@ -423,10 +415,8 @@ public JsonNode replace(String fieldName, JsonNode value)
      * returning instance after removal.
      * 
      * @return This node after removing entry (if any)
-     * 
-     * @since 2.1
      */
-    public JsonNode without(String fieldName)
+    public ObjectNode without(String fieldName)
     {
         _children.remove(fieldName);
         return this;
@@ -439,8 +429,6 @@ public JsonNode without(String fieldName)
      * @param fieldNames Names of fields to remove
      * 
      * @return This node after removing entries
-     * 
-     * @since 2.1
      */
     public ObjectNode without(Collection<String> fieldNames)
     {
@@ -567,9 +555,6 @@ public ObjectNode putPOJO(String fieldName, Object pojo) {
         return _put(fieldName, pojoNode(pojo));
     }
 
-    /**
-     * @since 2.6
-     */
     public ObjectNode putRawValue(String fieldName, RawValue raw) {
         return _put(fieldName, rawValueNode(raw));
     }
@@ -711,8 +696,6 @@ public ObjectNode put(String fieldName, BigDecimal v) {
      * Method for setting value of a field to specified numeric value.
      * 
      * @return This node (to allow chaining)
-     *
-     * @since 2.9
      */
     public ObjectNode put(String fieldName, BigInteger v) {
         return _put(fieldName, (v == null) ? nullNode()

src/test/java/com/fasterxml/jackson/databind/MapperViaParserTest.java renamed to src/test/java/com/fasterxml/jackson/failing/MapperViaParserTest.java

@@ -1,11 +1,12 @@
-package com.fasterxml.jackson.databind;
+package com.fasterxml.jackson.failing;
 
 import java.io.IOException;
 import java.io.StringReader;
 
 import com.fasterxml.jackson.core.*;
 import com.fasterxml.jackson.core.io.CharacterEscapes;
 import com.fasterxml.jackson.core.io.SerializedString;
+import com.fasterxml.jackson.databind.BaseMapTest;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class MapperViaParserTest  extends BaseMapTest