Skip to content

Commit 21314d4

Browse files
committed
Fix #2234 (manual merge to 2.10)
1 parent 00b5991 commit 21314d4

File tree

2 files changed

+30
-28
lines changed

2 files changed

+30
-28
lines changed

src/test/java/com/fasterxml/jackson/databind/ObjectMapperTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,15 +376,17 @@ public void testDataOutputViaMapper() throws Exception
376376
ByteArrayOutputStream bytes = new ByteArrayOutputStream();
377377
ObjectNode input = MAPPER.createObjectNode();
378378
input.put("a", 1);
379-
DataOutput data = new DataOutputStream(bytes);
380379
final String exp = "{\"a\":1}";
381-
MAPPER.writeValue(data, input);
380+
try (DataOutputStream data = new DataOutputStream(bytes)) {
381+
MAPPER.writeValue((DataOutput) data, input);
382+
}
382383
assertEquals(exp, bytes.toString("UTF-8"));
383384

384385
// and also via ObjectWriter...
385386
bytes.reset();
386-
data = new DataOutputStream(bytes);
387-
MAPPER.writer().writeValue(data, input);
387+
try (DataOutputStream data = new DataOutputStream(bytes)) {
388+
MAPPER.writer().writeValue((DataOutput) data, input);
389+
}
388390
assertEquals(exp, bytes.toString("UTF-8"));
389391
}
390392

src/test/java/com/fasterxml/jackson/databind/deser/jdk/JDKStringLikeTypesTest.java

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -359,34 +359,34 @@ public void testUUIDInvalid() throws Exception
359359

360360
public void testUUIDAux() throws Exception
361361
{
362-
// [JACKSON-393] fix:
363362
final UUID value = UUID.fromString("76e6d183-5f68-4afa-b94a-922c1fdb83f8");
364363

365364
// first, null should come as null
366-
TokenBuffer buf = new TokenBuffer(null, false);
367-
buf.writeObject(null);
368-
assertNull(MAPPER.readValue(buf.asParser(), UUID.class));
369-
buf.close();
365+
try (TokenBuffer buf = new TokenBuffer(null, false)) {
366+
buf.writeObject(null);
367+
assertNull(MAPPER.readValue(buf.asParser(), UUID.class));
368+
}
370369

371370
// then, UUID itself come as is:
372-
buf = new TokenBuffer(null, false);
373-
buf.writeObject(value);
374-
assertSame(value, MAPPER.readValue(buf.asParser(), UUID.class));
375-
376-
// and finally from byte[]
377-
// oh crap; JDK UUID just... sucks. Not even byte[] accessors or constructors? Huh?
378-
ByteArrayOutputStream bytes = new ByteArrayOutputStream();
379-
DataOutputStream out = new DataOutputStream(bytes);
380-
out.writeLong(value.getMostSignificantBits());
381-
out.writeLong(value.getLeastSignificantBits());
382-
byte[] data = bytes.toByteArray();
383-
assertEquals(16, data.length);
384-
385-
buf.writeObject(data);
386-
387-
UUID value2 = MAPPER.readValue(buf.asParser(), UUID.class);
388-
389-
assertEquals(value, value2);
390-
buf.close();
371+
try (TokenBuffer buf = new TokenBuffer(null, false)) {
372+
buf.writeObject(value);
373+
assertSame(value, MAPPER.readValue(buf.asParser(), UUID.class));
374+
375+
// and finally from byte[]
376+
// oh crap; JDK UUID just... sucks. Not even byte[] accessors or constructors? Huh?
377+
ByteArrayOutputStream bytes = new ByteArrayOutputStream();
378+
DataOutputStream out = new DataOutputStream(bytes);
379+
out.writeLong(value.getMostSignificantBits());
380+
out.writeLong(value.getLeastSignificantBits());
381+
out.close();
382+
byte[] data = bytes.toByteArray();
383+
assertEquals(16, data.length);
384+
385+
buf.writeObject(data);
386+
387+
UUID value2 = MAPPER.readValue(buf.asParser(), UUID.class);
388+
389+
assertEquals(value, value2);
390+
}
391391
}
392392
}

0 commit comments

Comments
 (0)