From 727e67409483a9b46b92e44157694f2f1aed2f44 Mon Sep 17 00:00:00 2001 From: Joe Schafer Date: Mon, 22 Jan 2018 01:36:08 -0800 Subject: [PATCH] Remove getClass from Class type From ErrorProne: src/main/java/com/fasterxml/jackson/databind/deser/std/FactoryBasedEnumDeserializer.java:184: error: [GetClassOnClass] Calling getClass() on an object of type Class returns the Class object for java.lang.Class; you probably meant to operate on the object directly wrapAndThrow(e, _valueClass.getClass(), prop.getName(), ctxt); ^ (see http://errorprone.info/bugpattern/GetClassOnClass) Did you mean 'wrapAndThrow(e, _valueClass, prop.getName(), ctxt);' or 'wrapAndThrow(e, Class.class, prop.getName(), ctxt);'? --- .../databind/deser/std/FactoryBasedEnumDeserializer.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/fasterxml/jackson/databind/deser/std/FactoryBasedEnumDeserializer.java b/src/main/java/com/fasterxml/jackson/databind/deser/std/FactoryBasedEnumDeserializer.java index 8b4f1ecfa0..ab4221c7f6 100644 --- a/src/main/java/com/fasterxml/jackson/databind/deser/std/FactoryBasedEnumDeserializer.java +++ b/src/main/java/com/fasterxml/jackson/databind/deser/std/FactoryBasedEnumDeserializer.java @@ -177,7 +177,7 @@ protected final Object _deserializeWithErrorWrapping(JsonParser p, Deserializati try { return prop.deserialize(p, ctxt); } catch (Exception e) { - wrapAndThrow(e, _valueClass.getClass(), prop.getName(), ctxt); + wrapAndThrow(e, _valueClass, prop.getName(), ctxt); // never gets here, unless caller declines to throw an exception return null; } @@ -205,4 +205,4 @@ private Throwable throwOrReturnThrowable(Throwable t, DeserializationContext ctx } return t; } -} \ No newline at end of file +}