[Suggestion] Luck Attribute to increase Random Crit Chance?

[SonicX8000]

I noticed that RLCombat has random crits and you can adjust the base chance in the config. I wonder if the Vanilla Luck Attribute can add onto the base chance where it would increase the odds of landing a random crit. An example...

Base chance in the config is 0.03 which... is a 3% chance, if the Player has 2.5 Luck, that would add... say... 5% (+0.02 aka 2% per 1 Luck if defined) onto that base value making it a 8% Crit Chance. The more Luck the player has the higher the Crit Chance Bonus. The config for how much Crit Chance to add per luck can be defined.

...also a question. Does the random crit chance only apply for melee hits? Would it be possible to allow the Random Crit Chance to apply from any attack from the player if using projectiles like from Bows, Staves, Guns, etc? Like a on-hit from the player. Or is that not do-able?

[fonnymunkey]

As melee crit handling posts a Forge event allowing anyone to modify whether or not an attack crits, I opted to not change it much beyond the option to change base chance and the option between random or jump crits.

I implemented luck based crits as an enchant instead in SoManyEnchantments 1.0.0+ https://www.curseforge.com/minecraft/mc-mods/so-many-enchantments called Luck Magnification.

For having luck affect crits in general, I would recommend making a suggestion to https://github.com/Nischhelm/RLCraft-Luckified https://www.curseforge.com/minecraft/mc-mods/luckified as the goal of that mod is to expand the usage of the luck attribute, or alternatively it can be accomplished with Crafttweaker scripts.

As for projectiles, they are a different system that RLCombat doesn't modify, and generally don't have any concept of crits in the first place (Technically arrows have a crit value, but it only means if the bow was fully pulled back or not.)
People have posted in the 1.12.2 modding discord of being able to use Crafttweaker scripts to add a psudo crit effect to projectiles, as well as that may be something for Luckified to handle.

[Nischhelm]

guess where they came from
discussed in Nischhelm/RLCraft-Luckified#3

bows already have a crit mechanic, it works differently though as you said. full draws (and draws with advanced power 4+) are critical meaning they get a random multiplier between x1.0 and x1.5

[SonicX8000]

guess where they came from discussed in Nischhelm/RLCraft-Luckified#3

When you mentioned RLCombat I took a look at it, but didn't see the Luck Attribute affecting Random Crit Chance, hence why I gave this a post but I had a feeling it prob would've been more fitted for RL Luckified.

I am aware of Luck Magnification playing a role with the Luck Attribute after messing around with it but that's only for damage, not chance.

Interesting that Bows have a crit already, if you fully charge up a shot & fire it... thought it was something else to be fair.

[fonnymunkey]

In the post-rewrite SME versions luck does actually increase chance as well as damage
https://github.com/FermiumModding/SoManyEnchantments-1.12.2/blob/master/src/main/java/com/shultrea/rin/enchantments/weapon/crits/EnchantmentLuckMagnification.java#L92

If the attack isn't already a crit, and nothing is specifically blocking it from being a crit, it rerolls based on luck * enchantlevel * 0.01 for up to 20% chance for the attack to be changed to a crit

[SonicX8000]

Ah, alright. When I gave it a go I only noticed the damage being changed but wasn't aware of it also affecting the chance as well.