Skip to content

Commit 5d51c89

Browse files
authored
Merge pull request #180 from Fliplet/fix/PS-422
Add changes to test on staging
2 parents 703207b + 161a675 commit 5d51c89

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

interface.html

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1872,10 +1872,13 @@ <h4><small>App submission status</small></h4>
18721872
<div class="app-build-progress-holder"><i class="fa fa-check-circle"></i> Completed</div>
18731873
\{{#if fileUrl}}
18741874
<div class="download-build"><a href="\{{fileUrl}}"><i class="fa fa-download"></i> Download file</a></div>\{{/if}}
1875+
\{{#if isAdmin}}
18751876
\{{#if debugFileUrl}}
18761877
<div class="download-build"><span class="label label-default">Admin</span> <a href="\{{debugFileUrl}}"><i class="fa fa-download"></i> Download debug app</a> <a href="https://support.apple.com/en-us/HT204460"><i class="fa fa-fw fa-question-circle-o"></i></a></div>
18771878
\{{else}}
1878-
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>\{{/if}}
1879+
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>
1880+
\{{/if}}
1881+
\{{/if}}
18791882
</td>
18801883
<td class="app-build-details">
18811884
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
@@ -1887,10 +1890,13 @@ <h4><small>App submission status</small></h4>
18871890
<div class="app-build-progress-holder"><i class="fa fa-bell"></i> \{{testingStatus}}</div>
18881891
\{{#if fileUrl}}
18891892
<div class="download-build"><a href="\{{fileUrl}}"><i class="fa fa-download"></i> Download file</a></div>\{{/if}}
1893+
\{{#if isAdmin}}
18901894
\{{#if debugFileUrl}}
18911895
<div class="download-build"><span class="label label-default">Admin</span> <a href="\{{debugFileUrl}}"><i class="fa fa-download"></i> Download debug app</a> <a href="https://support.apple.com/en-us/HT204460"><i class="fa fa-fw fa-question-circle-o"></i></a></div>
18921896
\{{else}}
1893-
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>\{{/if}}
1897+
<div class="download-build"><span class="label label-default">Admin</span> Debug app not available</div>
1898+
\{{/if}}
1899+
\{{/if}}
18941900
</td>
18951901
<td class="app-build-details">
18961902
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-clock-o"></i> Ready on:</span> \{{updatedAt}}</span>\{{/if}}
@@ -1927,7 +1933,7 @@ <h4><small>App submission status</small></h4>
19271933
\{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
19281934
<div class="app-build-name">\{{{message}}}</div>
19291935
</td>
1930-
\{{/if}}
1936+
\{{/if}}
19311937
\{{#if cancelled}}
19321938
<td class="app-build-progress warning">
19331939
<div class="app-build-progress-holder"><i class="fa fa-ban"></i> Canceled</div>

js/interface.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2155,8 +2155,9 @@ function checkSubmissionStatus(origin, iosSubmissions) {
21552155

21562156
if (submission.result.message) {
21572157
build.message = submission.result.message;
2158-
2159-
const gracefullyFailedMessage = "The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.";
2158+
2159+
const gracefullyFailedMessage = 'The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.';
2160+
21602161
if (submission.result.message === gracefullyFailedMessage) {
21612162
submission.status = 'gracefullyFailed';
21622163
}
@@ -2169,6 +2170,8 @@ function checkSubmissionStatus(origin, iosSubmissions) {
21692170
}
21702171

21712172
if (userInfo && userInfo.user && (userInfo.user.isAdmin || userInfo.user.isImpersonating)) {
2173+
build.isAdmin = userInfo.user.isAdmin || userInfo.user.isImpersonating;
2174+
console.log('build.isAdmin', build.isAdmin);
21722175
build.debugFileUrl = debugHtmlPage ? removeAuthTokenFromFileUrl(debugHtmlPage.url) : '';
21732176
}
21742177

0 commit comments

Comments
 (0)