Skip to content

Commit 4d7c773

Browse files
committed
Improve test coverage
1 parent 50e4cfe commit 4d7c773

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

test/specs/parsing/getBucketForSelector.tests.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,14 @@ describe('getBucketForSelector', () => {
3737
it('returns the correct bucket for expressions using the and operator, first not having a bucket', () => {
3838
assertBucketForSelector('true() and self::element()', 'type-1');
3939
});
40+
it('returns the correct bucket for expressions using the and operator, first matching nothing', () => {
41+
assertBucketForSelector('(self::element() and self::processing-instruction()) or self::element()', 'type-1');
42+
assertBucketForSelector('self::element() or (self::element() and self::processing-instruction())', 'type-1');
43+
});
44+
it('returns the correct bucket for expressions using nested operators, first matching everything', () => {
45+
assertBucketForSelector('(self::element() or self::processing-instruction()) or self::element()', null);
46+
assertBucketForSelector('self::element() or (self::element() or self::processing-instruction())', null);
47+
});
4048
it('returns the correct bucket for expressions using the or operator, first not having a bucket', () => {
4149
assertBucketForSelector('true() or self::element()', null);
4250
});

test/specs/parsing/operators/boolean/OrOperator.tests.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,13 @@ describe('or operator', () => {
2828
);
2929
});
3030

31+
it('can parse an "or" selector with different nonoverlapping buckets that does not match', () => {
32+
jsonMlMapper.parse(['c'], documentNode);
33+
chai.assert.isFalse(
34+
evaluateXPathToBoolean('self::a or self::b', documentNode.documentElement),
35+
);
36+
});
37+
3138
it('can parse a concatenation of ors', () =>
3239
chai.assert.isTrue(
3340
evaluateXPathToBoolean(

0 commit comments

Comments
 (0)