Encryption Breaks if modifyBackup sub reconciler runs

[millasml]

What happened?

The underlying issue is really in apple/foundationdb#12544, but having a modifyBackup sub reconciler that may run in each reconcile loop makes it impossible to guarantee that any backups started with encryption will have encryption throughout the lifetime of the backup resource.

I have staged #2392 to minimize the impact, but the issue still persists if there are any updates to snapshot seconds. the modifyBackup sub reconciler should be removed all together until the underlying foundationDB bug is fixed.

What did you expect to happen?

any modification to the backup resource does not break encryption, as long as the encryption key path is specified in the spec.

How can we reproduce it (as minimally and precisely as possible)?

change the snapshot seconds of a backup resource that has encryption key path specified.

Anything else we need to know?

No response

FDB Kubernetes operator

$ kubectl fdb version
foundationdb-operator: 2.14.0
kubectl-fdb: latest

Kubernetes version

$ kubectl version
Client Version: v1.32.2
Kustomize Version: v5.5.0
Server Version: v1.32.801

Cloud provider

aws

[johscheuer]

Thanks for opening the PR, I mentioned it in the PR: I think the best would be to skip the modify sub reconciler if the backup is encrypted.

[millasml]

new PR:
#2394