Skip to content

Commit 5f3c083

Browse files
committed
cover more test cases
1 parent f657063 commit 5f3c083

File tree

8 files changed

+188
-236
lines changed

8 files changed

+188
-236
lines changed

fdb-relational-core/src/main/java/com/apple/foundationdb/relational/recordlayer/query/visitors/ExpressionVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ public CompatibleTypeEvolutionPredicate.FieldAccessTrieNode visitUidListWithNest
754754
final var uidMap = Streams.mapWithIndex(ctx.uidWithNestings().stream(),
755755
(ctxWithNesting, index) -> {
756756
final var uid = visitUid(ctxWithNesting.uid());
757-
final var accessor = FieldValue.ResolvedAccessor.of(uid.getName(), (int)index, Type.any());
757+
final var accessor = FieldValue.ResolvedAccessor.of(DataTypeUtils.toProtoBufCompliantName(uid.getName()), (int)index, Type.any());
758758
if (ctxWithNesting.uidListWithNestingsInParens() == null) {
759759
return NonnullPair.of(accessor, CompatibleTypeEvolutionPredicate.FieldAccessTrieNode.of(Type.any(), null));
760760
} else {

yaml-tests/src/test/java/YamlIntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ public void castTests(YamlTest.Runner runner) throws Exception {
333333
}
334334

335335
@TestTemplate
336-
public void identifierTest(YamlTest.Runner runner) throws Exception {
337-
runner.runYamsql("identifiers.yamsql");
336+
public void validIdentifierTest(YamlTest.Runner runner) throws Exception {
337+
runner.runYamsql("valid-identifiers.yamsql");
338338
}
339339
}

yaml-tests/src/test/resources/identifiers.metrics.binpb

Lines changed: 0 additions & 67 deletions
This file was deleted.

yaml-tests/src/test/resources/identifiers.metrics.yaml

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)