When query fails, some functions stop working

[Zvbhrf]

Hello!

I've been using this library for a long time, but after rewriting my abstraction on it, I noticed some.. ?bugs? with some functions.

If your query, which is in transaction, fails with an error, then query:error() returns empty string, query:isRunning() stays true and query:hasMoreResults() throws an error.

I think it shouldn't be like that? Because when query fails, it should be marked as "not running" with correct error().

local db = database:GetDB() -- my own function, it returns mysqloo database object

local t = db:createTransaction()
local p = db:query("select * fom abc") -- query with syntax error
t:addQuery(p)

function t:onError(...)

	for _, q in ipairs(self:getQueries()) do
		print(q:error(), q:isRunning()) -- error() is empty, isRunning is true
		
		while q:hasMoreResults() do -- error goes here: Query not completed yet
			local queryData = databaseQuery:getData()
			print(queryData)
			
			databaseQuery:getNextResults()
		end
	end
end

t:start()

[Zvbhrf]

For some reason query:isRunning() from transaction:getQueries() returns true even with successful transactions.

[FredyH]

I am so sorry for the extremely long wait, but I think I finally managed to get around to this and fix it, you can try it in the latest Beta release.
Please note that query:isRunning() is expected to return true inside the callbacks, only after the callbacks will it start returning false.

I will close this issue for now, but if you notice any bugs with the change please let me know.

[Zvbhrf]

Now if transaction fails, then query:getData() returns nil.. query:hasMoreData() returns true

local db = your_database
local trans = db:createTransaction()

for i = 1, 10 do
	trans:addQuery(db:prepare("select * from artboard limit 10"))
end

-- comment this to see that on success it returns values
trans:addQuery(db:prepare("select *2 from artboard limit 10"))


local function RUN_TRANSACTION_CALLBACKS(transaction)
	for _, databaseQuery in ipairs(transaction:getQueries()) do
	    local err = databaseQuery:error()
	    if err == "" then
	        while databaseQuery:hasMoreResults() do
	            local queryData = databaseQuery:getData()
	            print(queryData) -- nils!
	
	            databaseQuery:getNextResults()
	        end
	    end
    end
end

function trans:onSuccess()
	print("success")
    RUN_TRANSACTION_CALLBACKS(self)
end

function trans:onError(err)
	print(err)
    RUN_TRANSACTION_CALLBACKS(self)
end

trans:start()

[FredyH]

I have made another attempt at fixing this issue in the latest beta.
The queries that are executed before the error occurs will return the data they retrieved in the transaction's error callback.
However, the queries after the error now are effectively aborted, hasMoreResults() will immediately return false and getData() will also return nil.

I think this is the most logical behavior and should fix your use case. Please let me know if you could get it to work.