Code Modernization: Address __wakeup() deprecation in PHP 8.5. #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.5 deprecates the `__sleep()` and `__wakeup()` magic methods in favor of `__serialize()` and `__unserialize()`. See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods For PHP < 7.4 compatibility, `__sleep()` and `__wakeup()` need to be kept for the time being. This commit moves the logic of the `__wakeup()` method to `__unserialize()`, and turns the former into a wrapper. The SDK does not use `__sleep()` methods, so this is the only change required.
|
Ok, this might need some more code to actually restore properties, see the ongoing discussion at https://core.trac.wordpress.org/ticket/63962#comment:11 and following comments. |
|
@TobiasBg looks like the deprecation was cancelled (like you said so in the ticket) https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup And we tried out an implementation here in #831 The implementation worked but it produced more boilerplate code (the exact reason for which the deprecation was cancelled). So I am also closing this as |
|
Hi @swashata! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.5 deprecates the
__sleep()and__wakeup()magic methods in favor of__serialize()and__unserialize().See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods
For PHP < 7.4 compatibility,
__sleep()and__wakeup()need to be kept for the time being.This commit moves the logic of the
__wakeup()method to__unserialize(), and turns the former into a wrapper. The SDK does not use__sleep()methods, so this is the only change required.