Skip to content

Commit c15e494

Browse files
committed
minor correction to sh installer
1 parent 68403a5 commit c15e494

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

docs/install.sh

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@ add_app_to_path() {
142142
# define target files
143143
FILES=("$HOME/.bashrc" "$HOME/.bash_profile" "$HOME/.profile")
144144

145+
local MODIFIED=false
146+
145147
# append to each file if it exists and doesn't already contain the entry
146148
for file in "${FILES[@]}"; do
147149
if [ -f "$file" ]; then
@@ -161,16 +163,21 @@ add_app_to_path() {
161163
source "$HOME/.bash_profile" 2>/dev/null
162164
echo "Successfully added $INSTALL_DIR to PATH."
163165
else
164-
echo "No config files were modified."
166+
echo "No PATH was modified."
165167
fi
166168
}
167169

168170
# installer itself
169171
installer() {
170172
echo "Hi! We'll install $APP_NAME ($ARCH edition) for you. Just a sec!"
171-
echo "Please note we'll use sudo a lot (many files to be created)"
173+
echo ""
174+
echo "Please note we'll use sudo a lot (many files to be created)."
172175
echo "They're all found at $INSTALL_DIR."
176+
echo ""
177+
echo "This script relies on you running from Bash 4 or later."
178+
echo ""
173179
install_app
180+
add_app_to_path
174181
echo "You may have seen our documentation mention shortcuts like 'fknode', 'fkn', 'fkclean'..."
175182
echo "These are made by creating a bunch of scripts (fknode.sh, fkn.sh...) next to the main installation."
176183
echo "We highly recommend them, but JUST IN CASE they conflicted with any other local command, we let you choose."
@@ -182,7 +189,6 @@ installer() {
182189
else
183190
echo "Okay, we WON'T create shortcuts. Beware, as documentation and help menus might still use them to refer to commands."
184191
fi
185-
add_app_to_path
186192
echo "Installed successfully! Restart your terminal for it to work."
187193
}
188194

0 commit comments

Comments
 (0)