Skip to content

Bugfix/152 bugfixes #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig8 merged 4 commits into from
Jun 25, 2025
Merged

Bugfix/152 bugfixes #184

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e02fb37
Fixing simulation.py dataclass defaults to use field
afisher1 Jun 20, 2025
971d463
fixing syntax errors and missing import.
afisher1 Jun 25, 2025
5ca4678
Merge branch 'develop' into bugfix/152
afisher1 Jun 25, 2025
db3b962
Update simulation.py
craig8 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gridappsd-python-lib/gridappsd/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
from dataclasses import dataclass, field,
from dataclasses import dataclass, field

import time
import logging
from typing import Dict, List, Union

import gridappsd.topics as t
from gridappsd import GridAPPSD
from . import json_extension as json

_log = logging.getLogger(__name__)
Expand Down Expand Up @@ -117,8 +119,8 @@ class Simulation:
add_onmeasurement_callback, add_oncomplete_callback or add_onstart_callback method respectively.
"""

def __init__(self, gapps: 'GridAPPSD', run_config: Union[Dict, SimulationConfig]):
assert type(gapps).__name__ == 'GridAPPSD', "Must be an instance of GridAPPSD"
def __init__(self, gapps: GridAPPSD, run_config: Union[Dict, SimulationConfig]):
assert isinstance(gapps, GridAPPSD), "Must be an instance of GridAPPSD"
if isinstance(run_config, SimulationConfig):
self._run_config = run_config.asdict()
elif isinstance(run_config, dict):
Expand Down
Loading