From 51eb6ad3ff9abe79ba5ef5297a79f6fa431b593c Mon Sep 17 00:00:00 2001
From: Hibatullah Fawwaz Hana <hiba.kudus@gmail.com>
Date: Sun, 22 Jun 2025 12:53:03 +0700
Subject: [PATCH] fix: log

---
 .../src/controllers/application_controller.ts | 35 ++++++++++++++++---
 functions/src/middlewares/auth_middleware.ts  |  3 --
 functions/src/utils/jwt.ts                    |  1 -
 3 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/functions/src/controllers/application_controller.ts b/functions/src/controllers/application_controller.ts
index d1dd5c4..196f036 100644
--- a/functions/src/controllers/application_controller.ts
+++ b/functions/src/controllers/application_controller.ts
@@ -109,8 +109,14 @@ async function saveData(
   uid: string
 ) {
   try {
+    functions.logger.info(
+      `Starting saveData for user ${uid} in state ${state}`
+    );
+    functions.logger.info(`Data to save: ${JSON.stringify(dataToSave)}`);
+
     // if currently in PROFILE state, then upsert data to `users` collection.
     if (state === APPLICATION_STATES.PROFILE) {
+      functions.logger.info(`Saving to users collection for state ${state}`);
       const userRef = db.collection("users").doc(uid);
       const userDoc = await userRef.get();
 
@@ -121,14 +127,23 @@ async function saveData(
       };
 
       if (!userDoc.exists) {
+        functions.logger.info(`Creating new user document for ${uid}`);
         data.createdAt = new Date().toISOString();
+      } else {
+        functions.logger.info(`Updating existing user document for ${uid}`);
       }
 
       await userRef.set(data, { merge: true });
+      functions.logger.info(
+        `Successfully saved to users collection for ${uid}`
+      );
     }
 
     // upsert other data in `application` section.
     else {
+      functions.logger.info(
+        `Saving to applications collection for state ${state}`
+      );
       const docRef = db.collection("applications").doc(uid);
       const doc = await docRef.get();
 
@@ -139,14 +154,23 @@ async function saveData(
       };
 
       if (!doc.exists) {
+        functions.logger.info(`Creating new application document for ${uid}`);
         data.createdAt = new Date().toISOString();
+      } else {
+        functions.logger.info(
+          `Updating existing application document for ${uid}`
+        );
       }
 
       await docRef.set(data, { merge: true });
+      functions.logger.info(
+        `Successfully saved to applications collection for ${uid}`
+      );
     }
   } catch (error) {
-    console.error("Error saving application:", error);
-    throw new Error("Failed to save application");
+    const err = error as Error;
+    functions.logger.error(`Error saving application for user ${uid}:`, err);
+    throw new Error(`Failed to save application: ${err.message}`);
   }
 }
 
@@ -526,7 +550,10 @@ function validateStringValue(fieldValue: string | any, question: Question) {
       field_id: `${question.id}`,
       message: `Must be at least ${validation.minLength} word(s)`,
     });
-  } else if (validation.maxLength && countWords(fieldValue) > validation.maxLength) {
+  } else if (
+    validation.maxLength &&
+    countWords(fieldValue) > validation.maxLength
+  ) {
     errors.push({
       field_id: `${question.id}`,
       message: `Must be less than ${validation.maxLength} word(s)`,
@@ -550,7 +577,7 @@ function validateStringValue(fieldValue: string | any, question: Question) {
   //     });
   //   }
   // }
-  
+
   return errors;
 }
 
diff --git a/functions/src/middlewares/auth_middleware.ts b/functions/src/middlewares/auth_middleware.ts
index 8202f9b..46ae735 100644
--- a/functions/src/middlewares/auth_middleware.ts
+++ b/functions/src/middlewares/auth_middleware.ts
@@ -39,9 +39,6 @@ export const validateSessionCookie = async (
   const sessionCookie = extractSessionCookieFromCookie(req);
   // Check for session cookie
   if (!sessionCookie) {
-    functions.logger.error(
-      "No session cookie found. Login for session cookies."
-    );
     res.status(401).json({
       status: 401,
       error: "No session cookie found",
diff --git a/functions/src/utils/jwt.ts b/functions/src/utils/jwt.ts
index d7f6ef0..c5f13da 100644
--- a/functions/src/utils/jwt.ts
+++ b/functions/src/utils/jwt.ts
@@ -35,7 +35,6 @@ export function extractSessionCookieFromCookie(req: Request) {
     sessionCookie = req.cookies.__session;
     return sessionCookie;
   }
-  functions.logger.warn("Cannot find __session cookie");
   return;
 }