Skip to content
This repository was archived by the owner on Feb 29, 2024. It is now read-only.

Commit 709e719

Browse files
Louis Yecopybara-github
authored andcommitted
Update TODO description for short-circuit evaluation
PiperOrigin-RevId: 326534664 Change-Id: Ia1a1df625aaef80037ff2658c88389cd959ab3a1
1 parent 1cdd148 commit 709e719

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/agent/binary_expression_evaluator.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,9 +468,8 @@ ErrorOr<JVariant> BinaryExpressionEvaluator::Evaluate(
468468
return arg1_value;
469469
}
470470

471-
// TODO: evaluate second argument on demand. For example in this one:
472-
// (true || exp)
473-
// "exp" should never be evaluated.
471+
// TODO: support short-circuit evaluation.
472+
// For example in this one: (true || exp), "exp" should never be evaluated.
474473
ErrorOr<JVariant> arg2_value = arg2_->Evaluate(evaluation_context);
475474
if (arg2_value.is_error()) {
476475
return arg2_value;

0 commit comments

Comments
 (0)