Table cells are not removed from view when removing the table

[velara3]

The cells are not removed from view when removing the table.

Steps to Reproduce

1. Click Add Table
2. Click Remove Table

Expected Results
Table is removed from text flow and no longer visible

Actual Results
Table is removed from the text flow object but the visual elements are still visible

[velara3]

This seems like it may require changes in replaceChildren. Possible fix is to add a check to see if the element is a Table and if so call table.removeAllRowsWithContent().

[Harbs]

replaceChildren() is designed so you can respond to it without modifying the function. replaceChildren() calls modelChanged() and passes in either ModelChange.ELEMENT_ADDED or ModelChange.ELEMENT_REMOVAL. modelChanged() is designed to be overridden by the subclasses to handle any additional class-specific cleanup necessary.

[velara3]

I'll check into it. In my tests it seems the modelChanged() is getting called when TableCellElements are added but not when the Table is removed.

[Harbs]

That makes sense. The function is called on the parent of the elements that are added/removed.

[velara3]

We may want to add an override so that the element itself has a chance to clean up. Maybe, element.removed() or element.modelChanged(ModelChange.REMOVED).

[velara3]

With the last update the shapes are now removed when the text flow is cleared but when the table element is removed by removeChild() an error is thrown.

ArgumentError: Child to remove not found
at flashx.textLayout.elements::FlowGroupElement/removeChild()[930]