Merge pull request #331 from Human-Connection/develop

Update Master and fix several issues

Author: roschaefer

.babelrc

@@ -0,0 +1,11 @@
+{
+  "env": {
+    "test": {
+      "plugins": ["transform-object-rest-spread"],
+      "presets": [
+        ["env", { "targets": { "node": "current" }}]
+      ]
+    }
+  }
+}
+

.eslintrc.js

@@ -6,6 +6,7 @@ module.exports = {
     sourceType: 'module'
   },
   env: {
+    jest: true,
     browser: true,
     node: true
   },

.travis.yml

@@ -27,17 +27,23 @@ after_success:
   - chmod +x send.sh
   - ./send.sh success $WEBHOOK_URL
   - if [ $TRAVIS_BRANCH == "master" ] && [ $TRAVIS_EVENT_TYPE == "push" ]; then
-    docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD";
-    docker tag humanconnection/frontend-nuxt humanconnection/frontend-nuxt:alpha;
-    docker push humanconnection/frontend-nuxt:alpha;
+    docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD" &&
+    docker tag humanconnection/frontend-nuxt humanconnection/frontend-nuxt:alpha &&
+    docker push humanconnection/frontend-nuxt:alpha &&
+    wget https://raw.githubusercontent.com/Human-Connection/Discord-Bot/develop/tester.sh &&
+    chmod +x tester.sh &&
+    ./tester.sh alpha $WEBHOOK_URL;
     fi
   - if [ $TRAVIS_BRANCH == "develop" ] && [ $TRAVIS_EVENT_TYPE == "push" ]; then
-    docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD";
-    docker tag humanconnection/frontend-nuxt humanconnection/frontend-nuxt:edge;
-    docker push humanconnection/frontend-nuxt:edge;
+    docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD" &&
+    docker tag humanconnection/frontend-nuxt humanconnection/frontend-nuxt:edge &&
+    docker push humanconnection/frontend-nuxt:edge &&
+    wget https://raw.githubusercontent.com/Human-Connection/Discord-Bot/develop/tester.sh &&
+    chmod +x tester.sh &&
+    ./tester.sh staging $WEBHOOK_URL;
     fi
 
 after_failure:
   - wget https://raw.githubusercontent.com/DiscordHooks/travis-ci-discord-webhook/master/send.sh
   - chmod +x send.sh
-- ./send.sh failure $WEBHOOK_URL
+  - ./send.sh failure $WEBHOOK_URL

CODE_OF_CONDUCT.md

@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at developer@human-connection.org. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

components/Contributions/ContributionsForm.vue

@@ -427,6 +427,7 @@
           return
         }
         this.$emit('validate', true)
+        this.editorText('')
 
         this.isLoading = true
 
@@ -452,6 +453,7 @@
         } catch (err) {
           console.error(err)
           this.isLoading = false
+          this.$emit('validate', false)
           this.$toast.open({
             message: err.message,
             type: 'is-danger'

components/Global/Elements/Icon/Icon.test.js

@@ -0,0 +1,8 @@
+import { shallowMount } from '@vue/test-utils'
+import Icon from './Icon'
+
+test('It should render an `<i>`.', () => {
+  const wrapper = shallowMount(Icon)
+
+  expect(wrapper.is('i')).toBeTruthy()
+})

components/layout/Topbar.vue

@@ -6,16 +6,16 @@
         :class="{ 'is-active': menuIsActive }">
         <div class="hc-navbar-item hc-navbar-brand">
           <h1 class="is-hidden">Human-Connection</h1>
-          <a class="hc-navbar-brand-logo"
-             @click="onLogoClick"
+          <nuxt-link to="/" class="hc-navbar-brand-logo"
+             @click.native="onLogoClick"
              :title="$t('component.layout.topbarLabel')">
             <img class="is-hidden-mobile"
                  src="/Logo-Horizontal-Alpha.svg"
                  alt="Human-Connection.org"/>
             <img class="is-hidden-tablet"
                  src="/Logo-Globe-Alpha.svg"
                  alt="Human-Connection.org"/>
-          </a>
+          </nuxt-link>
         </div>
         <div class="hc-navbar-item hc-navbar-search">
           <top-search></top-search>

components/mixins/protectable.js

@@ -1,7 +1,8 @@
 // This mixin can be loaded for every page component with input fields. It will confirm leaving the page in case the user has some (unsaved) input/draft pending.
 let protectable = {
   beforeRouteLeave (to, from, next) {
-    if (this.isComposing) {
+    next(false)
+    if (this.isComposing && !this.isSubmitting) {
       this.$dialog.confirm({
         title: this.$t('component.contribution.draft'),
         message: this.$t('component.contribution.draftMsg'),
@@ -17,6 +18,8 @@ let protectable = {
   },
   mounted () {
     window.addEventListener('beforeunload', this.beforeUnload)
+    this.isSubmitting = false
+    this.isComposing = false
   },
   beforeDestroy () {
     window.removeEventListener('beforeunload', this.beforeUnload)

package.json

@@ -37,7 +37,9 @@
     "eslint": "eslint --ext .js,.vue .",
     "styleguide": "vue-styleguidist server",
     "styleguide:build": "vue-styleguidist build",
-    "test": "ava",
+    "test": "yarn run test:jest && yarn run test:ava",
+    "test:jest": "jest",
+    "test:ava": "ava test/**/*.ava.js",
     "cypress:open": "cypress open",
     "cypress:run": "cypress run",
     "coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov"
@@ -116,10 +118,11 @@
   },
   "devDependencies": {
     "@nuxtjs/webpackmonitor": "~0.1.0",
-    "@vue/test-utils": "^1.0.0-beta.20",
-    "ava": "~0.25.0",
+    "@vue/server-test-utils": "^1.0.0-beta.25",
+    "@vue/test-utils": "^1.0.0-beta.25",
+    "ava": "^0.25.0",
+    "babel-jest": "^23.6.0",
     "backpack-core": "~0.7.0",
-    "browser-env": "~3.2.4",
     "codecov": "~3.0.4",
     "eslint": "~4.19.1",
     "eslint-config-standard": "~11.0.0-beta.0",
@@ -131,21 +134,39 @@
     "eslint-plugin-standard": "~3.1.0",
     "eslint-plugin-vue": "^4.5.0",
     "istanbul": "~0.4.5",
-    "jsdom": "~11.10.0",
+    "jest": "^23.6.0",
+    "jsdom": "^12.0.0",
+    "jsdom-global": "^3.0.2",
     "less": "~2.7.3",
     "less-loader": "^4.1.0",
     "node-sass": "~4.9.0",
     "require-extension-hooks": "~0.3.3",
     "require-extension-hooks-babel": "~0.1.1",
     "require-extension-hooks-vue": "~1.0.0",
     "sass-loader": "~6.0.7",
+    "sinon": "^6.3.4",
     "source-map-support": "~0.5.6",
     "vue-docgen-api": "^2.3.11",
+    "vue-jest": "^2.6.0",
     "vue-style-loader": "~4.1.0"
   },
   "ava": {
     "require": [
       "./test/helpers/setup.js"
     ]
+  },
+  "jest": {
+    "moduleFileExtensions": [
+      "js",
+      "json",
+      "vue"
+    ],
+    "moduleNameMapper": {
+      "^~/(.*)$": "<rootDir>/$1"
+    },
+    "transform": {
+      ".*\\.(vue)$": "vue-jest",
+      "^.+\\.js$": "<rootDir>/node_modules/babel-jest"
+    }
   }
 }

pages/contributions/edit/_slug.vue

@@ -1,10 +1,9 @@
 <template>
   <div class="columns">
-    <div class=" column is-8 is-offset-2">
-      <div class="card">
+    <div class="column is-8 is-offset-2">
+      <div class="card" :class="classes">
         <section class="section">
-          <!--<h1 class="title">Edit {{ title }}</h1>-->
-          <contributions-form :data="form"></contributions-form>
+          <contributions-form :data="form" v-on:input="editorText" @validate="onValidate" />
         </section>
       </div>
     </div>
@@ -13,12 +12,28 @@
 
 <script>
   import ContributionsForm from '~/components/Contributions/ContributionsForm.vue'
+  import animatable from '~/components/mixins/animatable'
+  import protectable from '~/components/mixins/protectable'
 
   export default {
     middleware: ['verified', 'owner'],
+    mixins: [animatable, protectable],
     components: {
       ContributionsForm
     },
+    methods: {
+      editorText (newText) {
+        this.protectText(newText)
+      },
+      onValidate (success) {
+        if (!success) {
+          this.animate('shake')
+          this.isSubmitting = false
+        } else {
+          this.isSubmitting = true
+        }
+      }
+    },
     async asyncData ({app, params, error}) {
       try {
         let res = await app.$api.service('contributions').find({