Skip to content

Conversation

@eiman-eltigani-ttd
Copy link
Contributor

Quick note, for the redirection directions (i.e. "Normally user would be redirected automatically, but this example demonstrates one way UID2 login could be handled." in examples/js-sdk/views/login.html), I left the word login in there becuase it is still referring to what is considered the real user login experience.

@ashleysmithTTD
Copy link
Contributor

ashleysmithTTD commented Jul 1, 2025

the secure signals react site needs updated as well, in SecureSignalsApp.tsx the buttons still say Log In and Log Out. Also, the ReadME for this site needs updating

@ashleysmithTTD
Copy link
Contributor

examples\google-secure-signals-integration\server_side\views\login.html still has Log In

@ashleysmithTTD
Copy link
Contributor

examples\google-secure-signals-integration\server_side\views\identity.html and uid2-web-integrations\examples\google-secure-signals-integration\with_sdk_v3\views\index.html both still have Log Out

@eiman-eltigani-ttd
Copy link
Contributor Author

Realized I missed a disclaimer in examples/google-secure-signals-integration/with_sdk_v3/views/index.html. Added that in addition to fixing disclaimer language per Gen's feedback

@eiman-eltigani-ttd eiman-eltigani-ttd merged commit 3062d65 into main Jul 1, 2025
3 checks passed
@eiman-eltigani-ttd eiman-eltigani-ttd deleted the eee-UID2-5666-rename-sample-login-buttons branch July 1, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants