Skip to content

Notification-state: Highlight failed notify attempt for better visibility #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Notification-state: Highlight failed notify attempt for better visibility #299

wants to merge 1 commit into from

Conversation

@sukhwinder33445
Copy link
Contributor

resolves #258

@sukhwinder33445 sukhwinder33445 self-assigned this Feb 13, 2025
@sukhwinder33445 sukhwinder33445 marked this pull request as draft February 13, 2025 15:58
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 13, 2025
@sukhwinder33445 sukhwinder33445 force-pushed the fix/visualize-notification-state branch from f5ee188 to ef82431 Compare February 13, 2025 15:59
@nilmerg nilmerg force-pushed the fix/visualize-notification-state branch from ef82431 to 074c701 Compare October 8, 2025 07:16
@nilmerg
Copy link
Member

nilmerg commented Oct 30, 2025

Render the (failed) text red please, nothing else gets colored. Colored icons, especially using the regular state colors, are a bad idea as they may be easily misinterpreted as severity change.

@sukhwinder33445 sukhwinder33445 force-pushed the fix/visualize-notification-state branch 2 times, most recently from ae31569 to f7d6476 Compare October 31, 2025 09:02
@sukhwinder33445 sukhwinder33445 force-pushed the fix/visualize-notification-state branch 2 times, most recently from cec5c68 to 6f09aa0 Compare October 31, 2025 09:22
@sukhwinder33445 sukhwinder33445 changed the title IncidentHistoryListItem: Use colored icon to visualise notification-state Notification-state: Highlight failed notify attempt for better visibility Oct 31, 2025
@sukhwinder33445
Notify-state: Highlight failed notify attempt for better visibility
2583ca7 
- Apply css classes and increase css specificity
@sukhwinder33445 sukhwinder33445 force-pushed the fix/visualize-notification-state branch from 6f09aa0 to 2583ca7 Compare October 31, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilmerg nilmerg Awaiting requested review from nilmerg

At least 1 approving review is required to merge this pull request.

Assignees

@sukhwinder33445 sukhwinder33445

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incident History says it contacted a user when it didn't

3 participants

@sukhwinder33445 @nilmerg