Validate & cache IW2 url instance at daemon start up

Author: yhabteab

internal/daemon/config.go

@@ -8,6 +8,8 @@ import (
 	"github.com/icinga/icinga-go-library/logging"
 	"github.com/icinga/icinga-go-library/utils"
 	"github.com/icinga/icinga-notifications/internal"
+	"fmt"
+	"net/url"
 	"os"
 	"time"
 )
@@ -25,6 +27,8 @@ type ConfigFile struct {
 	Icingaweb2URL string          `yaml:"icingaweb2-url"`
 	Database      database.Config `yaml:"database"`
 	Logging       logging.Config  `yaml:"logging"`
+
+	IcingaWeb2UrlParsed *url.URL // Parsed version of Icingaweb2URL
 }
 
 // SetDefaults implements the defaults.Setter interface.
@@ -44,6 +48,16 @@ func (c *ConfigFile) Validate() error {
 		return err
 	}
 
+	if c.Icingaweb2URL == "" {
+		return errors.New("icingaweb2-url must be set")
+	}
+
+	parsedUrl, err := url.Parse(c.Icingaweb2URL)
+	if err != nil {
+		return fmt.Errorf("invalid icingaweb2-url: %s", err)
+	}
+	c.IcingaWeb2UrlParsed = parsedUrl
+
 	return nil
 }
 

internal/incident/incident.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"net/url"
 	"strconv"
 	"sync"
 	"time"
@@ -271,12 +270,7 @@ func (i *Incident) RetriggerEscalations(ev *event.Event) {
 // The URL of the incident is constructed using the Icinga Web 2 URL configured in the daemon configuration,
 // and panics if it fails to parse that URL.
 func (i *Incident) MakeNotificationRequest(ev *event.Event) *plugin.NotificationRequest {
-	baseUrl, err := url.Parse(daemon.Config().Icingaweb2URL)
-	if err != nil {
-		i.Logger.Panicw("Failed to parse Icinga Web 2 URL", zap.String("url", daemon.Config().Icingaweb2URL), zap.Error(err))
-	}
-
-	incidentUrl := baseUrl.JoinPath("/notifications/incident")
+	incidentUrl := daemon.Config().IcingaWeb2UrlParsed.JoinPath("/notifications/incident")
 	incidentUrl.RawQuery = fmt.Sprintf("id=%d", i.ID)
 
 	return &plugin.NotificationRequest{