Comparing to binary representations doesn't work.

Author: Roland Hedberg

src/jwkest/jwk.py

@@ -300,8 +300,8 @@ def __eq__(self, other):
             assert isinstance(other, Key)
             assert self.__dict__.keys() == other.__dict__.keys()
 
-            for key, val in self.__dict__.items():
-                assert getattr(other, key) == val
+            for key in self.public_members:
+                assert getattr(other, key) == getattr(self, key)
         except AssertionError:
             return False
         else:

tests/test_0_jwk.py

@@ -203,5 +203,19 @@ def test_cmp_rsa_ec():
     else:
         assert False
 
+
+def test_cmp_neq_ec():
+    priv, pub = P256.key_pair()
+    _key1 = ECKey(x=pub[0], y=pub[1], d=priv, crv="P-256")
+    _key2 = ECKey(**ECKEY)
+
+    try:
+        assert _key1 == _key2
+    except AssertionError:
+        pass
+    else:
+        assert False
+
+
 if __name__ == "__main__":
-    test_cmp_rsa_ec()
+    test_cmp_neq_ec()