Merge pull request #6 from stof/required_gc_fields

Mark the gcId and gcClaimCode as required members in the result

Author: stof

manifest/api-2.json

@@ -247,7 +247,9 @@
       "required": [
         "creationRequestId",
         "cardInfo",
-        "status"
+        "status",
+        "gcClaimCode",
+        "gcId"
       ],
       "members": {
         "cardInfo": {

src/Result/CreateGiftCardResponse.php

@@ -26,12 +26,12 @@ class CreateGiftCardResponse extends Result
     private $status;
 
     /**
-     * @var string|null
+     * @var string
      */
     private $gcClaimCode;
 
     /**
-     * @var string|null
+     * @var string
      */
     private $gcId;
 
@@ -54,7 +54,7 @@ public function getCreationRequestId(): string
         return $this->creationRequestId;
     }
 
-    public function getGcClaimCode(): ?string
+    public function getGcClaimCode(): string
     {
         $this->initialize();
 
@@ -68,7 +68,7 @@ public function getGcExpirationDate(): ?\DateTimeImmutable
         return $this->gcExpirationDate;
     }
 
-    public function getGcId(): ?string
+    public function getGcId(): string
     {
         $this->initialize();
 
@@ -97,8 +97,8 @@ protected function populateResult(Response $response): void
         ]);
         $this->creationRequestId = (string) $data->creationRequestId;
         $this->status = (string) $data->status;
-        $this->gcClaimCode = ($v = $data->gcClaimCode) ? (string) $v : null;
-        $this->gcId = ($v = $data->gcId) ? (string) $v : null;
+        $this->gcClaimCode = (string) $data->gcClaimCode;
+        $this->gcId = (string) $data->gcId;
         $this->gcExpirationDate = ($v = $data->gcExpirationDate) ? new \DateTimeImmutable((string) $v) : null;
     }
 }