Only finish started HTTP connections

Author: drbrain

lib/influxdb/client/http.rb

@@ -51,11 +51,11 @@ def connect_with_retry
 
         yield http
       rescue *InfluxDB::NON_RECOVERABLE_EXCEPTIONS => e
-        http.finish
+        http.finish if http.started?
 
         raise InfluxDB::ConnectionError, InfluxDB::NON_RECOVERABLE_MESSAGE
       rescue Timeout::Error, *InfluxDB::RECOVERABLE_EXCEPTIONS => e
-        http.finish
+        http.finish if http.started?
 
         retry_count += 1
         unless (config.retry == -1 || retry_count <= config.retry) && !stopped?

spec/influxdb/client_spec.rb

@@ -39,6 +39,19 @@
     end
   end
 
+  describe "#connect_with_retry" do
+    it "raises InfluxDB::ConnectionError when the hostname is unknown" do
+      subject.config.retry = 0
+
+      allow_any_instance_of(Net::HTTP).to receive(:start) do
+        raise SocketError, "simulate getaddrinfo error"
+      end
+
+      error = InfluxDB::ConnectionError.new "Tried 0 times to reconnect but failed."
+      expect { subject.send(:connect_with_retry) }.to raise_error(InfluxDB::ConnectionError)
+    end
+  end
+
   describe "#full_url" do
     it "returns String" do
       expect(subject.send(:full_url, "/unknown")).to be_a String