Low impact fix for possible zombie items from MakePermanent action

Author: TwelveEyes

Assets/Scripts/Game/UserInterfaceWindows/DaggerfallInventoryWindow.cs

@@ -333,6 +333,9 @@ protected override void Setup()
             UpdateLocalTargetIcon();
             UpdateRemoteTargetIcon();
 
+            // Setup quest items
+            UpdateQuestItems();
+
             // Store toggle closed binding for this window
             SetupClosedBinding();
         }
@@ -779,6 +782,9 @@ public virtual void Refresh(bool refreshPaperDoll = true)
             UpdateLocalTargetIcon();
             UpdateRemoteTargetIcon();
 
+            // Refresh quest items
+            UpdateQuestItems();
+
             // Refresh paper doll
             if (refreshPaperDoll)
                 paperDoll.Refresh();
@@ -986,15 +992,51 @@ protected void UpdateAccessoryItemsDisplay()
                 // Update button and panel
                 ImageData image = DaggerfallUnity.Instance.ItemHelper.GetInventoryImage(item);
                 panel.BackgroundTexture = image.texture;
-                if (image.width != 0 && image.height != 0)
-                    panel.Size = new Vector2(image.width, image.height);
-                else
-                    panel.Size = new Vector2(image.texture.width, image.texture.height);
+                if (image.width != 0 && image.height != 0)
+                    panel.Size = new Vector2(image.width, image.height);
+                else
+                    panel.Size = new Vector2(image.texture.width, image.texture.height);
                 button.ToolTipText = item.LongName;
                 button.AnimatedBackgroundTextures = (item.IsEnchanted) ? magicAnimation.animatedTextures : null;
             }
         }
 
+        /// <summary>
+        /// Sync items permanency with virtual quest item.
+        /// </summary>
+        protected void SyncMakePermanent(DaggerfallUnityItem item)
+        {
+            if (item.IsQuestItem)
+            {
+                // Get quest item
+                Item questItem = GetQuestItem(item);
+
+                // Sync permanency between virtual quest item and actual inventory item
+                if (questItem != null && questItem.MadePermanent)
+                    item.MakePermanent();
+            }
+        }
+
+        /// <summary>
+        /// Updates quest items.
+        /// </summary>
+        protected void UpdateQuestItems()
+        {
+            if (localItems != null)
+            {
+                for (int i = 0; i < localItems.Count; i++)
+                {
+                    DaggerfallUnityItem item = localItems.GetItem(i);
+
+                    if (!item.IsQuestItem)
+                        continue;
+
+                    // Stuff to update
+                    SyncMakePermanent(item);
+                }
+            }
+        }
+
         #endregion
 
         #region Private Methods
@@ -2163,12 +2205,12 @@ private int GetNextArchive()
         /// <summary>
         /// Event raised when an item is hovered over in either list, the paperdoll, or accessories.
         /// </summary>
-        public enum ItemHoverLocation { Accessories, Paperdoll, LocalList, RemoteList }
-        public delegate void OnItemHoverHandler(DaggerfallUnityItem item, ItemHoverLocation loc);
-        public event OnItemHoverHandler OnItemHover;
-        protected virtual void RaiseOnItemHoverEvent(DaggerfallUnityItem item, ItemHoverLocation loc)
+        public enum ItemHoverLocation { Accessories, Paperdoll, LocalList, RemoteList }
+        public delegate void OnItemHoverHandler(DaggerfallUnityItem item, ItemHoverLocation loc);
+        public event OnItemHoverHandler OnItemHover;
+        protected virtual void RaiseOnItemHoverEvent(DaggerfallUnityItem item, ItemHoverLocation loc)
         {
-            OnItemHover?.Invoke(item, loc);
+            OnItemHover?.Invoke(item, loc);
         }
 
         protected virtual void PaperDoll_OnMouseMove(int x, int y)
@@ -2281,6 +2323,6 @@ private void OnCloseWindow()
             OnClose -= OnCloseWindow;
         }
 
-        #endregion  
+        #endregion
     }
 }