Skip to content

Default Salt Use #7

@ghost

Description

See here: https://github.com/JaCraig/Craig-s-Utility-Library/blob/master/Utilities/IO/Encryption/BaseClasses/SymmetricBase.cs#L140

This code supplies a default salt of Kosher - this use defeats the purpose. Please here here for a detailed discussion of how salts should be applied - the key point is that to be effective, they should be random. Relying on a fixed or default salt defeats the purpose.

I would suggest removing the default, and add a method to generate a random salt using a CSPRNG.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions