From 3164bc8012c71715a5fc890ddac6cc0cbe06b381 Mon Sep 17 00:00:00 2001 From: shaulfl <43341727+shaulfl@users.noreply.github.com> Date: Wed, 24 Oct 2018 15:30:15 +0300 Subject: [PATCH 1/3] notify clients when publisher stopped broadcasting In my use case I'm using ngnix-rtmp as rtmp proxy. When rtmp publisher disconnects, ffmpeg rtmp subscribers hangs indefinitely, and manually closing ffmpeg causes file corruption. This pull request resolves this issue by notifying client on publish/unpublish so ffmpeg exits gracefully. --- run.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/run.sh b/run.sh index 6fb8628..903dc59 100755 --- a/run.sh +++ b/run.sh @@ -90,6 +90,7 @@ echo Creating stream $STREAM_NAME cat >>${NGINX_CONFIG_FILE} < Date: Wed, 24 Oct 2018 16:04:55 +0300 Subject: [PATCH 2/3] disable hls --- run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.sh b/run.sh index 903dc59..6fc48b0 100755 --- a/run.sh +++ b/run.sh @@ -81,7 +81,7 @@ else PUSH="true" fi -HLS="true" +HLS="false" for STREAM_NAME in $(echo ${RTMP_STREAMS}) do From 7f90bd468e62e245e9e9ecf49936d1b3a6d12c9a Mon Sep 17 00:00:00 2001 From: ShaulMyplay <43341727+ShaulMyplay@users.noreply.github.com> Date: Sun, 6 Oct 2019 12:51:05 +0300 Subject: [PATCH 3/3] Update Dockerfile add build arg to fix build issue --- Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Dockerfile b/Dockerfile index 16f4d85..9e84b24 100644 --- a/Dockerfile +++ b/Dockerfile @@ -45,6 +45,7 @@ RUN cd /tmp && \ ./configure \ --prefix=/opt/nginx \ --with-http_ssl_module \ + --with-cc-opt="-Wimplicit-fallthrough=0" \ --add-module=../nginx-rtmp-module && \ make && \ make install