feat: lint plugin tests

Author: Mqxx

deno.json

@@ -114,6 +114,7 @@
     "@esbuild": "npm:esbuild@^0.25.11",
     "@solid-js": "npm:solid-js@1.9.10",
     "@solid-js/router": "npm:@solidjs/router@^0.15.3",
+    "@std/assert": "jsr:@std/assert@^1.0.15",
     "@std/cli": "jsr:@std/cli@^1.0.6",
     "@std/http": "jsr:@std/http@^1.0.6",
     "@std/fmt": "jsr:@std/fmt@^1.0.2",

deno.lock

@@ -0,0 +1,134 @@
+import colonSpacing from './colon_spacing.ts';
+import { assertEquals } from '@std/assert';
+
+Deno.test('colon-spacing plugin', async (test) => {
+  await test.step('after-function rule, no space', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(arg1: string, arg2: number): string { 
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 1);
+
+    const diagnostic = diagnostics[0];
+
+    assertEquals(diagnostic.id, 'colon-spacing/after-function');
+    assertEquals(diagnostic.message, 'Wrong colon spacing. Expected 1 space after function.');
+    assertEquals(diagnostic.fix, [{range: [54, 54], text: ' '}]);
+  });
+
+  await test.step('after-function rule, too many spaces', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(arg1: string, arg2: number)  : string { 
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 1);
+
+    const diagnostic = diagnostics[0];
+
+    assertEquals(diagnostic.id, 'colon-spacing/after-function');
+    assertEquals(diagnostic.message, 'Wrong colon spacing. Expected 1 space after function.');
+    assertEquals(diagnostic.fix, [{range: [54, 56], text: ' '}]);
+  });
+
+  await test.step('before-type rule, no space', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(prop1: string, prop2: number) :string {
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 1);
+
+    const diagnostic = diagnostics[0];
+
+    assertEquals(diagnostic.id, 'colon-spacing/before-type');
+    assertEquals(diagnostic.message, 'Wrong colon spacing. Expected 1 space before type.');
+    assertEquals(diagnostic.fix, [{range: [58, 58], text: ' '}]);
+  });
+
+  await test.step('before-type rule, too many spaces', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(prop1: string, prop2: number) :  string {
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 1);
+
+    const diagnostic = diagnostics[0];
+
+    assertEquals(diagnostic.id, 'colon-spacing/before-type');
+    assertEquals(diagnostic.message, 'Wrong colon spacing. Expected 1 space before type.');
+    assertEquals(diagnostic.fix, [{range: [58, 60], text: ' '}]);
+  });
+
+  await test.step('before-type rule, no space, both', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(prop1: string, prop2: number):string {
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 2);
+
+    const afterFunctionDiagnostic = diagnostics[0];
+    const beforeTypeDiagnostic = diagnostics[1];
+
+    assertEquals(afterFunctionDiagnostic.id, 'colon-spacing/after-function');
+    assertEquals(afterFunctionDiagnostic.message, 'Wrong colon spacing. Expected 1 space after function.');
+    assertEquals(afterFunctionDiagnostic.fix, [{range: [56, 56], text: ' '}]);
+
+    assertEquals(beforeTypeDiagnostic.id, 'colon-spacing/before-type');
+    assertEquals(beforeTypeDiagnostic.message, 'Wrong colon spacing. Expected 1 space before type.');
+    assertEquals(beforeTypeDiagnostic.fix, [{range: [57, 57], text: ' '}]);
+  });
+
+  await test.step('before-type rule, too many spaces, both', () => {
+    const diagnostics = Deno.lint.runPlugin(
+      colonSpacing,
+      'main.ts',
+      `
+      export function Foo(prop1: string, prop2: number)  :  string {
+        return 'Hello World!';
+      }
+      `
+    )
+
+    assertEquals(diagnostics.length, 2);
+
+    const afterFunctionDiagnostic = diagnostics[0];
+    const beforeTypeDiagnostic = diagnostics[1];
+
+    assertEquals(afterFunctionDiagnostic.id, 'colon-spacing/after-function');
+    assertEquals(afterFunctionDiagnostic.message, 'Wrong colon spacing. Expected 1 space after function.');
+    assertEquals(afterFunctionDiagnostic.fix, [{range: [56, 58], text: ' '}]);
+
+    assertEquals(beforeTypeDiagnostic.id, 'colon-spacing/before-type');
+    assertEquals(beforeTypeDiagnostic.message, 'Wrong colon spacing. Expected 1 space before type.');
+    assertEquals(beforeTypeDiagnostic.fix, [{range: [59, 61], text: ' '}]);
+  });
+});

lint/plugins/colon_spacing.test.ts

@@ -17,9 +17,31 @@ export default {
 
               if (index !== -1 && sectionEnd - sectionStart !== 1) {
                 context.report({
-                  message: `Wrong colon spacing.`,
+                  message: `Wrong colon spacing. Expected 1 space after function.`,
                   range: [sectionStart - 1, sectionEnd + 1],
-                  fix(fixer) {
+                  fix(fixer) : Deno.lint.Fix{
+                    return fixer.replaceTextRange([sectionStart, sectionEnd], ' ');
+                  }
+                });
+              }
+            }
+          }
+        };
+      }
+    },
+    'before-type': {
+      create(context): Deno.lint.LintVisitor {
+        return {
+          TSTypeAnnotation(node): void {
+            if (node.parent.type === 'FunctionDeclaration') {
+              const sectionStart = node.range[0] + 1;
+              const sectionEnd = node.typeAnnotation.range[0];
+
+              if (sectionEnd - sectionStart !== 1) {
+                context.report({
+                  message: `Wrong colon spacing. Expected 1 space before type.`,
+                  range: [sectionStart - 1, sectionEnd + 1],
+                  fix(fixer) : Deno.lint.Fix{
                     return fixer.replaceTextRange([sectionStart, sectionEnd], ' ');
                   }
                 });

lint/plugins/colon_spacing.ts

@@ -2,7 +2,7 @@ import { createSignal, type JSXElement } from '@solid-js';
 
 import './index.css';
 
-export function ToggleSwitch(_foo: string, _bar: string) : JSXElement {
+export function ToggleSwitch() : JSXElement {
   const [state, setState] = createSignal(false);
 
   const toggle = () => {