[IR] Drop valueArgumentsCount from IrCallImpl

KT-70057

Author: mcpiroman

compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/backend/Fir2IrFakeOverrideStrategy.kt

@@ -350,8 +350,7 @@ class Fir2IrDelegatedMembersGenerationStrategy(
             offset,
             callReturnType,
             delegateTargetFunction.symbol,
-            delegatedFunction.typeParameters.size,
-            delegatedFunction.valueParameters.size
+            delegatedFunction.typeParameters.size
         ).apply {
             val thisDispatchReceiverParameter = delegatedFunction.dispatchReceiverParameter!!
             val getField = IrGetFieldImpl(

compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/Fir2IrBuiltinSymbolsContainer.kt

@@ -135,6 +135,7 @@ class Fir2IrBuiltinSymbolsContainer(
             constructorSymbol,
             typeArgumentsCount = 0,
             constructorTypeArgumentsCount = 0,
+            valueArgumentsCount = 0,
         )
     }
 

compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/AdapterGenerator.kt

@@ -284,7 +284,6 @@ internal class AdapterGenerator(
                     type,
                     adapteeSymbol,
                     typeArgumentsCount = callableReferenceAccess.typeArguments.size,
-                    valueArgumentsCount = firAdaptee.valueParameters.size + firAdaptee.contextReceivers.size,
                     origin = null,
                     superQualifierSymbol = null
                 )
@@ -676,8 +675,7 @@ internal class AdapterGenerator(
             startOffset, endOffset,
             adapterFunction.returnType,
             invokeSymbol,
-            typeArgumentsCount = 0,
-            valueArgumentsCount = adapterFunction.valueParameters.size
+            typeArgumentsCount = 0
         )
         irCall.dispatchReceiver = adapterFunction.extensionReceiverParameter!!.toIrGetValue(startOffset, endOffset)
         for (irAdapterParameter in adapterFunction.valueParameters) {

compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt

@@ -587,7 +587,6 @@ class CallAndReferenceGenerator(
                         startOffset, endOffset, irType,
                         declarationStorage.findGetterOfProperty(irSymbol),
                         typeArgumentsCount = calleeReference.toResolvedCallableSymbol()!!.fir.typeParameters.size,
-                        valueArgumentsCount = 0,
                         origin = IrStatementOrigin.GET_LOCAL_PROPERTY,
                         superQualifierSymbol = dispatchReceiver?.superQualifierSymbolForFunctionAndPropertyAccess()
                     )
@@ -767,7 +766,6 @@ class CallAndReferenceGenerator(
                         setterSymbol != null -> IrCallImpl(
                             startOffset, endOffset, type, setterSymbol,
                             typeArgumentsCount = firProperty.typeParameters.size,
-                            valueArgumentsCount = 1 + firProperty.contextReceivers.size,
                             origin = origin,
                             superQualifierSymbol = variableAssignment.dispatchReceiver?.superQualifierSymbolForFunctionAndPropertyAccess()
                         ).apply {
@@ -812,7 +810,6 @@ class CallAndReferenceGenerator(
                     IrCallImpl(
                         startOffset, endOffset, type, symbol,
                         typeArgumentsCount = firFunction?.typeParameters?.size ?: 0,
-                        valueArgumentsCount = 1,
                         origin = origin
                     ).apply {
                         putValueArgument(0, irRhsWithCast)
@@ -1243,8 +1240,7 @@ class CallAndReferenceGenerator(
                     startOffset, endOffset,
                     firConversionFunction.fir.returnTypeRef.toIrType(),
                     irConversionFunction,
-                    typeArgumentsCount = 0,
-                    valueArgumentsCount = 0
+                    typeArgumentsCount = 0
                 ).apply {
                     extensionReceiver = this@applyToElement
                 }

compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/OperatorExpressionGenerator.kt

@@ -317,7 +317,6 @@ internal class OperatorExpressionGenerator(
             irExpression.startOffset, irExpression.endOffset,
             conversionFirFunction.resolvedReturnType.toIrType(c),
             conversionFunctionSymbol as IrSimpleFunctionSymbol,
-            valueArgumentsCount = 0,
             typeArgumentsCount = 0
         ).also {
             it.dispatchReceiver = irExpression

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/ir/IrInlineUtils.kt

@@ -121,7 +121,7 @@ fun IrInlinable.inline(target: IrDeclarationParent, arguments: List<IrValueDecla
             val invoke = invokable.type.getClass()!!.functions.single { it.name == OperatorNameConventions.INVOKE }
             IrCallImpl(
                 UNDEFINED_OFFSET, UNDEFINED_OFFSET, invoke.returnType, invoke.symbol,
-                typeArgumentsCount = 0, valueArgumentsCount = arguments.size,
+                typeArgumentsCount = 0,
             ).apply {
                 dispatchReceiver = IrGetValueImpl(UNDEFINED_OFFSET, UNDEFINED_OFFSET, invokable.symbol)
                 for ((index, argument) in arguments.withIndex()) {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/ir/IrUtils.kt

@@ -112,7 +112,6 @@ fun CommonBackendContext.createArrayOfExpression(
         arrayType,
         ir.symbols.arrayOf,
         typeArgumentsCount = 1,
-        valueArgumentsCount = 1
     ).apply {
         putTypeArgument(0, arrayElementType)
         putValueArgument(0, arg0)

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/DefaultArgumentStubGenerator.kt

@@ -365,7 +365,6 @@ open class DefaultParameterInjector<TContext : CommonBackendContext>(
                 IrCallImpl(
                     startOffset, endOffset, (it as IrSimpleFunctionSymbol).owner.returnType, it,
                     typeArgumentsCount = typeArgumentsCount - typeParametersToRemove,
-                    valueArgumentsCount = it.owner.valueParameters.size,
                     origin = LoweredStatementOrigins.DEFAULT_DISPATCH_CALL,
                     superQualifierSymbol = superQualifierSymbol
                 )

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/EnumWhenLowering.kt

@@ -165,8 +165,7 @@ open class EnumWhenLowering(protected open val context: CommonBackendContext) :
         return IrCallImpl(
             expression.startOffset, expression.endOffset,
             expression.type, expression.symbol,
-            typeArgumentsCount = 0,
-            valueArgumentsCount = 2
+            typeArgumentsCount = 0
         ).apply {
             putValueArgument(0, IrGetValueImpl(lhs.startOffset, lhs.endOffset, subjectOrdinal.type, subjectOrdinal.symbol))
             putValueArgument(1, IrConstImpl.int(rhs.startOffset, rhs.endOffset, context.irBuiltIns.intType, entryOrdinal))

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/LocalDeclarationsLowering.kt

@@ -631,7 +631,6 @@ open class LocalDeclarationsLowering(
                 oldCall.type,
                 newCallee.symbol,
                 typeArgumentsCount = newCallee.typeParameters.size,
-                valueArgumentsCount = newCallee.valueParameters.size,
                 origin = oldCall.origin,
                 superQualifierSymbol = oldCall.superQualifierSymbol
             ).also {