Describe your changes

Author: John75SunCity

.devcontainer/devcontainer.json

@@ -5,7 +5,8 @@
   "customizations": {
     "vscode": {
       "extensions": [
-        "tht13.python"
+        "tht13.python",
+        "GitHub.copilot"
       ]
     }
   }

.vscode/extensions.json

@@ -0,0 +1,5 @@
+{
+    "recommendations": [
+        "github.copilot"
+    ]
+}

records_management/models/pickup_request.py

@@ -20,7 +20,7 @@ class PickupRequest(models.Model):
     )
     request_date = fields.Date(
         string='Request Date',
-        default=fields.Date.today,
+        default=lambda self: fields.Date.today(),
         required=True,
         help="The date when the pickup is requested. Cannot be in the past."
     )
@@ -32,7 +32,6 @@ class PickupRequest(models.Model):
     item_ids = fields.Many2many(
         'stock.production.lot',
         string='Items',
-        domain="[('customer_id', '=', customer_id)]",
         help="Items to be picked up. Only items belonging to the selected customer are allowed."
     )
 
@@ -43,16 +42,19 @@ def _check_request_date(self):
         """
         for rec in self:
             if rec.request_date and rec.request_date < fields.Date.today():
+            if rec.request_date and fields.Date.from_string(rec.request_date) < fields.Date.from_string(fields.Date.today()):
                 raise ValidationError("The request date cannot be in the past.")
-
     @api.constrains('item_ids', 'customer_id')
     def _check_item_customer(self):
         """
         Ensure all selected items belong to the selected customer.
         """
         for rec in self:
             if rec.customer_id and rec.item_ids:
-                invalid_items = rec.item_ids.filtered(lambda l: l.customer_id != rec.customer_id)
+                invalid_items = rec.item_ids.search([
+                    ('id', 'in', rec.item_ids.ids),
+                    ('customer_id', '!=', rec.customer_id.id)
+                ])
                 if invalid_items:
                     raise ValidationError("All items must belong to the selected customer.")
 

records_management/models/scrm_records_management.py

@@ -1,9 +1,15 @@
-# (Odoo manifest dictionary removed from Python file. Place it in __manifest__.py instead.)
+"""
+Odoo manifest dictionary has been removed from this Python file.
+Please place the manifest dictionary in a separate __manifest__.py file as required by Odoo module structure.
+"""
 from odoo import fields, models, api, _
 from odoo.exceptions import ValidationError, AccessError
 from odoo import http
 from odoo.http import request
 
+# Constant for the pickup request form field name
+PICKUP_ITEM_IDS_FIELD = 'item_ids'
+
 class StockProductionLot(models.Model):
     _inherit = 'stock.production.lot'
 
@@ -12,7 +18,7 @@ class StockProductionLot(models.Model):
 
 class ShreddingService(models.Model):
     _name = 'shredding.service'
-    _description = 'Document Shredding Service'
+    service_date = fields.Date(string='Service Date', default=lambda self: fields.Date.today())
 
     customer_id = fields.Many2one('res.partner', string='Customer', required=True)
     service_date = fields.Date(string='Service Date', default=fields.Date.today)
@@ -27,7 +33,7 @@ class ShreddingService(models.Model):
                                         domain=[('customer_id', '!=', False)])
     audit_barcodes = fields.Text(string='Audit Barcodes')
     total_charge = fields.Float(string='Total Charge', compute='_compute_total_charge')
-    timestamp = fields.Datetime(string='Service Timestamp', default=fields.Datetime.now)
+    timestamp = fields.Datetime(string='Service Timestamp', default=lambda self: fields.Datetime.now())
     latitude = fields.Float(string='Latitude')
     longitude = fields.Float(string='Longitude')
     attachment_ids = fields.Many2many('ir.attachment', string='Attachments')
@@ -59,7 +65,10 @@ def _compute_total_charge(self):
             if record.service_type == 'bin':
                 record.total_charge = len(record.bin_ids) * 10.0
             else:
-                qty = record.box_quantity or len(record.shredded_box_ids) or 0
+                if record.box_quantity is not None:
+                    qty = record.box_quantity
+                else:
+                    qty = len(record.shredded_box_ids) or 0
                 record.total_charge = qty * 5.0
 
     @api.depends('latitude', 'longitude')
@@ -90,8 +99,11 @@ class PickupRequest(models.Model):
     request_date = fields.Date(string='Request Date', default=fields.Date.today)
     state = fields.Selection([
         ('draft', 'Draft'),
-        ('confirmed', 'Confirmed'),
-        ('done', 'Done')
+    item_ids = fields.Many2many(
+        'stock.production.lot',
+        string='Items',
+        domain=lambda self: [('customer_id', '=', self.customer_id.id)] if self.customer_id else []
+    )
     ], default='draft', string='Status')
     item_ids = fields.Many2many('stock.production.lot', string='Items', 
                                 domain="[('customer_id', '=', customer_id)]")
@@ -180,7 +192,7 @@ def request_pickup(self, **post):
         if request.httprequest.method == 'POST':
             try:
                 # Sanitize and validate item_ids
-                raw_ids = request.httprequest.form.getlist('item_ids')
+                raw_ids = request.httprequest.form.getlist(PICKUP_ITEM_IDS_FIELD)
                 item_ids = [int(id) for id in raw_ids if id.isdigit()]
                 if not item_ids:
                     error = _("Please select at least one item for pickup.")
@@ -195,6 +207,11 @@ def request_pickup(self, **post):
             'serials': serials,
             'error': error
         })
+        serials = self._get_serials(partner)
+        return request.render('records_management.pickup_request_form', {
+            'serials': serials,
+            'error': error
+        })
 
 # --- Placeholders for test coverage (to be implemented in test modules) ---
 # def test_compute_total_charge(self): ...

records_management/models/stock_picking.py

@@ -4,15 +4,30 @@ class StockPicking(models.Model):
     _inherit = 'stock.picking'
 
     def button_validate(self):
+        """
+        Overrides the core button_validate to create a sale order for retrieval fees
+        when an outgoing picking is validated and items are grouped by customer.
+        """
         res = super().button_validate()
         if self.state == 'done' and self.picking_type_id.code == 'outgoing':
-            customer_items = self.move_line_ids.filtered(lambda ml: ml.lot_id and ml.lot_id.customer_id)
+            # Filter move lines that have a lot with a customer
+            customer_items = self.move_line_ids.filtered(lambda l: l.lot_id and l.lot_id.customer_id)
             if customer_items:
-                customer = customer_items[0].lot_id.customer_id
-                self.env['sale.order'].create({
-                    'partner_id': customer.id,
-                    'order_line': [(0, 0, {
-                        'product_id': self.env.ref('records_management.retrieval_fee_product').id,
+                # Group items by customer
+                customers = {}
+                for item in customer_items:
+                    customer = item.lot_id.customer_id
+                    customers.setdefault(customer, []).append(item)
+                for customer, items in customers.items():
+                    self.env['sale.order'].create({
+                        'partner_id': customer.id,
+                        'order_line': [(0, 0, {
+                            'product_id': self.env.ref('records_management.retrieval_fee_product').id,
+                            'product_uom_qty': len(items),
+                        })],
+                    })
+                        })],
+                    })
                         'product_uom_qty': len(customer_items),
                     })],
                 })

records_management/models/stock_production_lot.py

@@ -1,4 +1,17 @@
-from odoo import fields, models  # type: ignore
+"""
+Developer Note:
+To optimize database queries, prefer using search_read or read_group instead of multiple .search() calls.
+Example:
+serials = request.env['stock.production.lot'].search_read(
+    [('customer_id', '=', partner.id)], ['id']
+)
+quants = request.env['stock.quant'].search_read(
+    [('lot_id', 'in', [s['id'] for s in serials]), ('location_id.usage', '=', 'internal')],
+    ['id', 'lot_id', 'location_id']
+)
+"""
+
+from odoo import fields, models
 
 class StockProductionLot(models.Model):
     _inherit = 'stock.production.lot'
@@ -8,14 +21,3 @@ class StockProductionLot(models.Model):
         string='Customer',
         help='Tracks ownership. Customer-owned items (boxes, files) have a customer_id; company-owned bins may leave it empty or use it for assignment.'
     )
-
-    # Developer Note:
-    # To optimize database queries, prefer using search_read or read_group instead of multiple .search() calls.
-    # Example:
-    # serials = request.env['stock.production.lot'].search_read(
-    #     [('customer_id', '=', partner.id)], ['id']
-    # )
-    # quants = request.env['stock.quant'].search_read(
-    #     [('lot_id', 'in', [s['id'] for s in serials]), ('location_id.usage', '=', 'internal')],
-    #     ['id', 'lot_id', 'location_id']
-    # )