refactor: Improve logging format and clean up imports across multiple files

Author: odoo

records_management/__init__.py

@@ -18,8 +18,9 @@ def _post_init_hook(env):
             import logging
             _logger = logging.getLogger(__name__)
             _logger.warning(
-                f"Required module '{module_name}' is not installed. "
-                f"Please install it for full functionality."
+                "Required module '%s' is not installed. "
+                "Please install it for full functionality.",
+                module_name
             )
 
     # Initialize sequences if needed

records_management/controllers/portal.py

@@ -1,5 +1,5 @@
 from odoo import http
-from odoo.http import request
+
 
 class InventoryPortal(http.Controller):
     @http.route('/my/inventory', type='http', auth='user', website=True)

records_management/models/installer.py

@@ -1,7 +1,8 @@
 # -*- coding: utf-8 -*-
-from odoo import models, fields, api, _
+from odoo import models, api, _
 from odoo.exceptions import UserError
 
+
 class RecordsManagementInstaller(models.TransientModel):
     _name = 'records.management.installer'
     _description = 'Records Management Installation Helper'

records_management/models/pickup_request.py

@@ -1,21 +1,35 @@
 from odoo import models, fields, api
-from odoo.exceptions import ValidationError
+
 
 class PickupRequest(models.Model):
     _name = 'pickup.request'
     _description = 'Pickup Request'
     _inherit = ['mail.thread', 'mail.activity.mixin']
 
-    name = fields.Char(string='Name', required=True, default='New', tracking=True)
-    customer_id = fields.Many2one('res.partner', string='Customer', required=True, tracking=True)
-    request_date = fields.Date(string='Request Date', default=fields.Date.context_today, required=True, tracking=True)
-    request_item_ids = fields.One2many('pickup.request.item', 'pickup_id', string='Request Items')
+    name = fields.Char(
+        string='Name', required=True, default='New', tracking=True
+    )
+    customer_id = fields.Many2one(
+        'res.partner', string='Customer', required=True, tracking=True
+    )
+    request_date = fields.Date(
+        string='Request Date', default=fields.Date.context_today,
+        required=True, tracking=True
+    )
+    request_item_ids = fields.One2many(
+        'pickup.request.item', 'pickup_id', string='Request Items'
+    )
     notes = fields.Text(string='Notes')
 
     # New fields
-    product_id = fields.Many2one('product.product', string='Product', required=True, tracking=True)
+    product_id = fields.Many2one(
+        'product.product', string='Product', required=True, tracking=True
+    )
     quantity = fields.Float(string='Quantity', required=True, tracking=True)
-    lot_id = fields.Many2one('stock.lot', string='Lot', domain="[('product_id', '=', product_id)]")
+    lot_id = fields.Many2one(
+        'stock.lot', string='Lot',
+        domain="[('product_id', '=', product_id)]"
+    )
 
     # Status tracking
     state = fields.Selection([
@@ -28,10 +42,20 @@ class PickupRequest(models.Model):
 
     # Additional fields for the view
     scheduled_date = fields.Date(string='Scheduled Date', tracking=True)
-    warehouse_id = fields.Many2one('stock.warehouse', string='Warehouse', tracking=True)
-    driver_id = fields.Many2one('res.partner', string='Driver', domain="[('is_company', '=', False)]", tracking=True)
-    vehicle_id = fields.Many2one('fleet.vehicle', string='Vehicle', tracking=True)
-    priority = fields.Selection([('0', 'Normal'), ('1', 'High')], default='0', string='Priority', tracking=True)
+    warehouse_id = fields.Many2one(
+        'stock.warehouse', string='Warehouse', tracking=True
+    )
+    driver_id = fields.Many2one(
+        'res.partner', string='Driver',
+        domain="[('is_company', '=', False)]", tracking=True
+    )
+    vehicle_id = fields.Many2one(
+        'fleet.vehicle', string='Vehicle', tracking=True
+    )
+    priority = fields.Selection(
+        [('0', 'Normal'), ('1', 'High')], default='0',
+        string='Priority', tracking=True
+    )
     signature = fields.Binary(string='Signature')
     signed_by = fields.Many2one('res.users', string='Signed By')
     signature_date = fields.Datetime(string='Signature Date')
@@ -71,5 +95,8 @@ def action_cancel(self):
     def create(self, vals_list):
         for vals in vals_list:
             if vals.get('name', 'New') == 'New':
-                vals['name'] = self.env['ir.sequence'].next_by_code('pickup.request') or 'New'
+                vals['name'] = (
+                    self.env['ir.sequence'].next_by_code('pickup.request')
+                    or 'New'
+                )
         return super().create(vals_list)

records_management/models/records_document.py

@@ -1,6 +1,5 @@
 from odoo import models, fields, api, _
-from odoo.exceptions import UserError
-from datetime import datetime, timedelta
+
 
 class RecordsDocument(models.Model):
     _name = 'records.document'
@@ -9,14 +8,18 @@ class RecordsDocument(models.Model):
     _order = 'date desc, name'
 
     name = fields.Char('Document Reference', required=True, tracking=True)
-    box_id = fields.Many2one('records.box', string='Box', required=True,
-                            tracking=True, index=True,
-                            domain="[('state', '=', 'active')]")
-    location_id = fields.Many2one(related='box_id.location_id',
-                                 string='Storage Location', store=True)
+    box_id = fields.Many2one(
+        'records.box', string='Box', required=True, tracking=True,
+        index=True, domain="[('state', '=', 'active')]"
+    )
+    location_id = fields.Many2one(
+        related='box_id.location_id', string='Storage Location', store=True
+    )
 
     # Document metadata
-    document_type_id = fields.Many2one('records.document.type', string='Document Type')
+    document_type_id = fields.Many2one(
+        'records.document.type', string='Document Type'
+    )
     date = fields.Date('Document Date', default=fields.Date.context_today)
     description = fields.Html('Description')
     tags = fields.Many2many('records.tag', string='Tags')

records_management/models/records_tag.py

@@ -1,8 +1,9 @@
-from odoo import models, fields, api, _
+from odoo import models, fields, api
 import logging
 
 _logger = logging.getLogger(__name__)
 
+
 class RecordsTag(models.Model):
     _name = 'records.tag'
     _description = 'Records Management Tag'

records_management/models/stock_picking.py

@@ -1,4 +1,5 @@
-from odoo import api, models  # type: ignore
+from odoo import models  # type: ignore
+
 
 class StockPicking(models.Model):
     _inherit = 'stock.picking'
@@ -11,7 +12,9 @@ def button_validate(self):
         res = super().button_validate()
         if self.state == 'done' and self.picking_type_id.code == 'outgoing':
             # Filter move lines that have a lot with a customer
-            customer_items = self.move_line_ids.filtered(lambda l: l.lot_id and l.lot_id.customer_id)
+            customer_items = self.move_line_ids.filtered(
+                lambda line: line.lot_id and line.lot_id.customer_id
+            )
             if customer_items:
                 # Group items by customer
                 customers = {}
@@ -22,7 +25,9 @@ def button_validate(self):
                     self.env['sale.order'].create({
                         'partner_id': customer.id,
                         'order_line': [(0, 0, {
-                            'product_id': self.env.ref('records_management.retrieval_fee_product').id,
+                            'product_id': self.env.ref(
+                                'records_management.retrieval_fee_product'
+                            ).id,
                             'product_uom_qty': len(items),
                         })],
                     })