fix: Remove SQL constraints on code length, gracefully handle existing data

- Removed SQL constraint 'code_length_check' from records.department
- Softened Python validation to auto-clean codes (no length enforcement)
- Updated customer_code_display to handle any length (takes first 4 chars)
- Portal barcode generation now uses re.sub to sanitize all codes
- Codes are recommended to be 4 chars but existing data is handled gracefully

Author: John75SunCity

records_management/controllers/portal.py

@@ -2575,11 +2575,13 @@ def portal_container_create(self, **post):
                 import re
 
                 # Get 4-char company code (prefer customer_code field, fallback to ref)
-                if partner.customer_code and len(partner.customer_code) == 4:
-                    company_code = partner.customer_code.upper()
+                # Always take first 4 alphanumeric chars and pad if needed
+                if partner.customer_code:
+                    company_code = re.sub(r'[^A-Za-z0-9]', '', partner.customer_code).upper()[:4].ljust(4, '0')
+                elif partner.ref:
+                    company_code = re.sub(r'[^A-Za-z0-9]', '', partner.ref).upper()[:4].ljust(4, '0')
                 else:
-                    raw_company_ref = partner.ref or 'CUST'
-                    company_code = re.sub(r'[^A-Za-z0-9]', '', raw_company_ref).upper()[:4].ljust(4, '0')
+                    company_code = 'CUST'
 
                 # Build barcode prefix based on department hierarchy
                 barcode_prefix = f'TMP-{company_code}'
@@ -2591,15 +2593,17 @@ def portal_container_create(self, **post):
                 if department_id:
                     department = request.env['records.department'].sudo().browse(int(department_id))
                     if department.exists():
-                        # Get 4-char department code (should already be validated as 4 chars)
-                        dept_code = (department.code or 'DEPT').upper()[:4].ljust(4, '0')
+                        # Get 4-char department code (take first 4 chars, pad if needed)
+                        raw_code = department.code or 'DEPT'
+                        dept_code = re.sub(r'[^A-Za-z0-9]', '', raw_code).upper()[:4].ljust(4, '0')
                         barcode_prefix += f'-{dept_code}'
 
                         # Check if this department has a parent (making it a child dept)
                         if department.parent_department_id:
                             # This IS a child department - get parent code too
                             parent_dept = department.parent_department_id
-                            parent_code = (parent_dept.code or 'PRNT').upper()[:4].ljust(4, '0')
+                            raw_parent = parent_dept.code or 'PRNT'
+                            parent_code = re.sub(r'[^A-Za-z0-9]', '', raw_parent).upper()[:4].ljust(4, '0')
                             # Rebuild prefix: TMP-COMPANY-PARENT-CHILD
                             barcode_prefix = f'TMP-{company_code}-{parent_code}-{dept_code}'
 

records_management/models/records_department.py

@@ -89,29 +89,27 @@ class RecordsDepartment(models.Model):
         ('name_company_uniq', 'unique(name, company_id)', 'Department name must be unique per company.'),
         ('code_company_uniq', 'unique(code, company_id)', 'Department code must be unique per company.'),
         ('name_partner_uniq', 'UNIQUE(name, partner_id, company_id)', 'The department name must be unique per customer.'),
-        ('code_length_check', 'CHECK(LENGTH(code) = 4)', 'Department code must be exactly 4 characters.'),
+        # NOTE: No length constraint - we recommend 4 chars but gracefully handle existing data
     ]
 
     # ============================================================================
     # VALIDATION
     # ============================================================================
     @api.constrains('code')
     def _check_code_format(self):
-        """Ensure department code is exactly 4 alphanumeric characters."""
+        """
+        Normalize department code to uppercase alphanumeric.
+        Recommends 4 characters but gracefully handles existing data by
+        auto-truncating or padding to 4 chars for barcode generation.
+        """
         import re
         for dept in self:
             if dept.code:
-                # Remove any non-alphanumeric and check length
-                clean_code = re.sub(r'[^A-Za-z0-9]', '', dept.code)
-                if len(clean_code) != 4:
-                    raise ValidationError(
-                        _("Department code must be exactly 4 alphanumeric characters.\n"
-                          "Examples: HR01, LGL1, FIN2, ACCT\n"
-                          "Current value: '%s' (%d chars)") % (dept.code, len(dept.code))
-                    )
-                # Auto-uppercase and clean
-                if dept.code != clean_code.upper():
-                    dept.code = clean_code.upper()
+                # Remove any non-alphanumeric and uppercase
+                clean_code = re.sub(r'[^A-Za-z0-9]', '', dept.code).upper()
+                # Auto-fix: just clean and uppercase, don't enforce length
+                if clean_code and dept.code != clean_code:
+                    dept.code = clean_code
 
     # ============================================================================
     # COMPUTE METHODS

records_management/models/res_partner.py

@@ -299,11 +299,14 @@ def _compute_customer_code_display(self):
         """
         Compute the 4-character code used in temp barcodes.
         Priority: customer_code > ref (sanitized) > 'CUST'
+        Always returns exactly 4 characters (truncated or padded).
         """
         import re
         for partner in self:
-            if partner.customer_code and len(partner.customer_code) == 4:
-                partner.customer_code_display = partner.customer_code.upper()
+            if partner.customer_code:
+                # Take first 4 alphanumeric chars, pad if needed
+                clean_code = re.sub(r'[^A-Za-z0-9]', '', partner.customer_code).upper()[:4]
+                partner.customer_code_display = clean_code.ljust(4, '0') if clean_code else 'CUST'
             elif partner.ref:
                 # Sanitize ref to alphanumeric only, take first 4 chars
                 clean_ref = re.sub(r'[^A-Za-z0-9]', '', partner.ref).upper()[:4]
@@ -313,20 +316,18 @@ def _compute_customer_code_display(self):
 
     @api.constrains('customer_code')
     def _check_customer_code_format(self):
-        """Ensure customer code is exactly 4 alphanumeric characters if set."""
+        """
+        Normalize customer code to uppercase alphanumeric.
+        Recommends 4 characters but gracefully handles existing data.
+        """
         import re
         for partner in self:
             if partner.customer_code:
-                clean_code = re.sub(r'[^A-Za-z0-9]', '', partner.customer_code)
-                if len(clean_code) != 4:
-                    raise ValidationError(
-                        _("Customer Code must be exactly 4 alphanumeric characters.\\n"
-                          "Examples: 0915, CITY, PASO, ABC1\\n"
-                          "Current value: '%s' (%d chars)") % (partner.customer_code, len(partner.customer_code))
-                    )
-                # Auto-uppercase and clean
-                if partner.customer_code != clean_code.upper():
-                    partner.customer_code = clean_code.upper()
+                # Remove any non-alphanumeric and uppercase
+                clean_code = re.sub(r'[^A-Za-z0-9]', '', partner.customer_code).upper()
+                # Auto-fix: just clean and uppercase, don't enforce length
+                if clean_code and partner.customer_code != clean_code:
+                    partner.customer_code = clean_code
 
     @api.depends('department_ids')
     def _compute_department_count(self):