fix: Convert visualization_dynamic_loader.js to vanilla JavaScript

EASIEST CONVERSION (0 jQuery calls):
- Organization chart dynamic library loader
- Already used vanilla JavaScript internally
- Only needed to remove odoo.define() and publicWidget wrapper

CONVERSION DETAILS:
- Removed: odoo.define(), publicWidget
- Kept: All existing vanilla JavaScript logic (injectTag, ensureAssets)
- Added: Auto-initialization on DOMContentLoaded
- Pattern: IIFE with object literal

FUNCTIONALITY PRESERVED:
✓ Dynamic vis-network library loading (local → CDN fallback)
✓ Prevents committing large minified vendor bundles
✓ Loads only when diagram containers present
✓ Async script loading with proper error handling

FILES COMPLETED (2/4):
✅ portal_barcode_management.js (30 jQuery → vanilla)
✅ visualization_dynamic_loader.js (0 jQuery → vanilla)

FILES REMAINING (2/4):
⏳ portal_signature.js (47 jQuery calls - HIGH PRIORITY for e-signatures)
⏳ portal_inventory_highlights.js (37 jQuery calls - MEDIUM PRIORITY)

Next: Convert portal_signature.js for destruction certificate signing

Author: John75SunCity

records_management/__manifest__.py

@@ -785,9 +785,9 @@
         # Optional heavy visualization bundle loaded only when flowchart / portal diagram features are enabled.
         # This reduces baseline asset generation time for generic back-end usage and speeds up unit test asset build.
         "records_management.assets_visualization_optional": [
-            # TEMPORARILY DISABLED - Need vanilla JS conversion (publicWidget unavailable in frontend)
+            # ✅ RE-ENABLED - Converted to vanilla JavaScript (organization chart dynamic loader)
             # Dynamic loader replaces large minified vendor bundles to satisfy repo guideline (no minified libs committed)
-            # "records_management/static/src/js/visualization_dynamic_loader.js",
+            "records_management/static/src/js/visualization_dynamic_loader.js",
             # Local placeholder CSS (unminified real library recommended for production replacement)
             "records_management/static/src/lib/vis/vis-network.css",
             "records_management/static/src/xml/customer_portal_diagram_templates.xml"

records_management/static/src/js/visualization_dynamic_loader.js

@@ -3,12 +3,12 @@
  * Lightweight dynamic loader that fetches visualization libraries (vis-network)
  * from a CDN only when a diagram container is present. Avoids committing large
  * minified vendor bundles into the repository while preserving functionality.
+ *
+ * DEPENDENCIES: NONE (Pure vanilla JavaScript)
  */
-odoo.define('records_management.visualization_dynamic_loader', ['web.public.widget'], function (require) {
+(function () {
     'use strict';
 
-    const publicWidget = require('web.public.widget');
-
     // Local (served by Odoo) preferred paths
     const LOCAL_JS = '/records_management/static/src/lib/vis/vis-network.js';
     const LOCAL_CSS = '/records_management/static/src/lib/vis/vis-network.css';
@@ -19,7 +19,9 @@ odoo.define('records_management.visualization_dynamic_loader', ['web.public.widg
     const CDN_CSS = `https://unpkg.com/vis-network@${CDN_VERSION}/dist/vis-network.min.css`;
 
     function injectTag(tag, attrs, marker) {
-        if (document.querySelector(`[data-vis-network="${marker}"]`)) { return Promise.resolve(); }
+        if (document.querySelector(`[data-vis-network="${marker}"]`)) { 
+            return Promise.resolve(); 
+        }
         return new Promise((resolve, reject) => {
             const el = document.createElement(tag);
             Object.entries(attrs).forEach(([k,v]) => el.setAttribute(k, v));
@@ -60,15 +62,24 @@ odoo.define('records_management.visualization_dynamic_loader', ['web.public.widg
         }
     }
 
-    publicWidget.registry.VisualizationDynamicLoader = publicWidget.Widget.extend({
+    const VisualizationDynamicLoader = {
         selector: '.o_portal_organization_diagram, .o_system_flowchart_view',
-        start: function () {
-            if (this.el) {
+        
+        init() {
+            const elements = document.querySelectorAll(this.selector);
+            if (elements.length > 0) {
                 ensureAssets();
             }
-            return this._super.apply(this, arguments);
-        },
-    });
+        }
+    };
+
+    // Auto-initialize on page load
+    if (document.readyState === 'loading') {
+        document.addEventListener('DOMContentLoaded', () => VisualizationDynamicLoader.init());
+    } else {
+        VisualizationDynamicLoader.init();
+    }
 
-    return publicWidget.registry.VisualizationDynamicLoader;
-});
+    // Expose globally
+    window.RecordsManagementVisualizationDynamicLoader = VisualizationDynamicLoader;
+})();