Skip to content

Commit 54ae75f

Browse files
YunchuWangJoshVanL
authored andcommitted
Improve logging for unexpected connection failures in DurableTaskGrpcWorker (microsoft#216)
1 parent 785bcf0 commit 54ae75f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## placeholder
2+
* Improve logging for unexpected connection failures in DurableTaskGrpcWorker ([#216](https://github.com/microsoft/durabletask-java/pull/216/files))
23
* Add User-Agent Header to gRPC Metadata ([#213](https://github.com/microsoft/durabletask-java/pull/213))
34
## v1.5.0-preview.1
45
* Update protobuf definitions to include new properties in OrchestratorRequest and update source commit hash ([#214](https://github.com/microsoft/durabletask-java/pull/214))

client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ else if (requestType == RequestCase.HEALTHPING)
187187
} else if (e.getStatus().getCode() == Status.Code.CANCELLED) {
188188
logger.log(Level.INFO, "Durable Task worker has disconnected from {0}.", this.getSidecarAddress());
189189
} else {
190-
logger.log(Level.WARNING, "Unexpected failure connecting to {0}.", this.getSidecarAddress());
190+
logger.log(Level.WARNING, String.format("Unexpected failure connecting to %s", this.getSidecarAddress()), e);
191191
}
192192

193193
// Retry after 5 seconds

0 commit comments

Comments
 (0)