Skip to content

Commit ed8a4e6

Browse files
sonjusunsonjusun
authored andcommitted
feat : initNote 에러 수정
- findNote 와 findUserNotes 에서 정상적으로 보이도록 수정
1 parent d2a648f commit ed8a4e6

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

src/main/java/umc/th/juinjang/api/limjang/service/response/UserNoteGetResponse.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,18 @@ public static UserNoteGetResponse of(boolean isShared, Limjang note, Address add
3838
note.getPriceType(),
3939
note.getNickname(),
4040
note.getImageList().stream().map(Image::getImageUrl).limit(3).toList(),
41-
address.getRoadAddress(),
42-
address.getAddressDetail(),
41+
address != null ? address.getRoadAddress() : null,
42+
address != null ? address.getAddressDetail() : null,
4343
note.getLimjangPrice().getPrice(note.getPriceType(), note.getPurpose()),
4444
note.getPriceType() == LimjangPriceType.MONTHLY_RENT ? note.getLimjangPrice().getMonthlyRent() : null,
4545
note.getUpdatedAt().format(DateTimeFormatter.ofPattern("yy.MM.dd")),
4646
note.getFloor(),
4747
note.getPyong(),
48-
address.getBcode(),
49-
address.getSido(),
50-
address.getSigungo(),
51-
address.getBname1(),
52-
address.getBname2()
48+
address != null ? address.getBcode() : null,
49+
address != null ? address.getSido() : null,
50+
address != null ? address.getSigungo() : null,
51+
address != null ? address.getBname1() : null,
52+
address != null ? address.getBname2() : null
5353
);
5454
}
5555
}

src/main/java/umc/th/juinjang/domain/limjang/repository/LimjangRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Optional<Limjang> findByLimjangIdAndMemberIdWithLimjangPriceAndDeletedIsFalse(@P
5757
@Query("SELECT l FROM Limjang l WHERE l.limjangId = :id AND l.deleted = false")
5858
Optional<Limjang> findByLimjangIdAndDeletedIsFalse(@Param("id") Long id);
5959

60-
@Query("SELECT l FROM Limjang l join fetch l.addressEntity join fetch l.limjangPrice WHERE l.limjangId = :id AND l.deleted = false")
60+
@Query("SELECT l FROM Limjang l left join fetch l.addressEntity left join fetch l.limjangPrice WHERE l.limjangId = :id AND l.deleted = false")
6161
Optional<Limjang> findByIdWithAddressAndNotePriceWhereDeletedIsFalse(@Param("id") Long id);
6262

6363
@Query("SELECT l FROM Limjang l join fetch l.addressEntity join fetch l.limjangPrice left join fetch l.report WHERE l.memberId = :member AND l.deleted = false AND l.isSharable = true")

src/test/java/umc/th/juinjang/api/limjang/service/command/InitNoteTest.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -117,18 +117,7 @@ void initNoteDetailAreVisible() {
117117

118118
UserNoteGetResponse response = noteQueryService.findNote(createdNoteId);
119119
log.info("### response : {} ", response);
120-
assertInitNoteBasicFields(response, createdNoteId);
121-
}
122-
123-
// 헬퍼 메서드들
124-
private NoteInitRequest createInitRequest() {
125-
return new NoteInitRequest(
126-
LimjangPurpose.RESIDENTIAL_PURPOSE,
127-
LimjangPropertyType.APARTMENT,
128-
LimjangPriceType.MONTHLY_RENT,
129-
"50000",
130-
"4000"
131-
);
120+
132121
}
133122

134123
private void assertInitNoteBasicFields(UserNotesGetResponse.UserNoteResponse note, Long expectedId) {

0 commit comments

Comments
 (0)