Skip to content

Avoid piracy #1248

New issue
New issue
Open
#1302
Open
Avoid piracy#1248
#1302
@aplavin

Description

@aplavin
aplavin
opened on Mar 9, 2024

StaticArrays does some piracy, at least in similar():

StaticArrays.jl/src/abstractarray.jl

Lines 141 to 146 in 07c1245

const HeterogeneousBaseShape = Union{Integer, Base.OneTo}
const HeterogeneousShape = Union{HeterogeneousBaseShape, SOneTo}
const HeterogeneousShapeTuple = Tuple{Vararg{HeterogeneousShape}}
similar(A::AbstractArray, ::Type{T}, shape::HeterogeneousShapeTuple) where {T} = similar(A, T, homogenize_shape(shape))
similar(::Type{A}, shape::HeterogeneousShapeTuple) where {A<:AbstractArray} = similar(A, homogenize_shape(shape))

Here,

HeterogeneousShapeTuple = Tuple{Vararg{Union{Integer, Base.OneTo, SOneTo} }}

and it fits eg Tuple{}, Tuple{Int}, Tuple{Int, Int}.

It's generally a good thing to avoid piracy in foundational packages. Maybe, also related to ambiguities like JuliaArrays/StructArrays.jl#279?..

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions