Skip to content

Commit 0665717

Browse files
lievenheymilianw
authored andcommitted
feat: remove memory leak when calling QLayout::replaceWidget
1 parent ec54b1e commit 0665717

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/callgraphwidget.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ CallgraphWidget::CallgraphWidget(Data::CallerCalleeResults results, KParts::Read
4242
generateCallgraph(m_currentSymbol);
4343
});
4444

45-
layout()->replaceWidget(ui->graphPlaceholder, view->widget());
45+
auto oldWidget = layout()->replaceWidget(ui->graphPlaceholder, view->widget());
46+
delete oldWidget;
4647

4748
updateColors();
4849
m_interface->setLayoutMethod(KGraphViewer::KGraphViewerInterface::LayoutMethod::InternalLibrary);

src/frequencypage.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ FrequencyPage::FrequencyPage(PerfParser* parser, QWidget* parent)
5151

5252
m_page->setupUi(this);
5353

54-
m_page->layout->replaceWidget(m_page->plotWidget, m_plot);
54+
auto oldWidget = m_page->layout->replaceWidget(m_page->plotWidget, m_plot);
55+
delete oldWidget;
5556

5657
auto plotData = QSharedPointer<PlotData>::create();
5758

0 commit comments

Comments
 (0)