Skip to content

Buggy display of part upgrade costs #340

@Starstrider42

Description

@Starstrider42

What did you do before the bug occurred?

The bug can be reproduced with KSP 1.12.5, Module Manager 4.2.3, KSP CF 1.39.1, Harmony 2 2.2.1.0, and BonVoyage 1.5.0.0. KSP_COMMUNITY_FIXES.UpgradeBugs must be set to true (as it is by default).

  1. Create a new sandbox game, with "All Part Upgrades Applied in Sandbox" set under Advanced Difficulty Options. [Note: the bug was originally detected in a career save]
  2. Go to the VAB.
  3. In the parts panel, mouse over any of the "capsule" or aerospace command pods. The base price is given.
  4. Mouse over either the Probodobodyne RoveMate or the Mk2 Lander Can. The price is given in the form "√[total price] + √[upgrade price]"
  5. Mouse over the command pod(s) from step 3. The price is given in the same form as step 4; while the base price is correct (i.e., unchanged), the "+ √[upgrade price]" is not because there are no upgrades.

What happened?

  • I would expect that upgrade prices are only listed for parts that actually have upgrades, and not "carried over" from the last upgradable part viewed.
  • The price display implies that the two prices given are added together, when the first price is the "everything included" one (confirmed both by construction and by inspecting the PARTUPGRADE nodes). It would be less confusing to either:
    • list the base price first, followed by the upgrade in the current notation, or
    • list the total price, followed by something like "(includes √[upgrade price] upgrades)"

Addendum: with the settings above, there should be two upgrades applied: BonVoyageUpgrade_v2 for √1000, and BonVoyageUpgrade_v3 for √1250. It appears that, while both upgrades are listed in the ModuleInfo, BonVoyageUpgrade_v3 supersedes BonVoyageUpgrade_v2 for pricing purposes; I'm not sure if this is intended behavior or another bug.

Upload your ksp.log file

https://gist.github.com/Starstrider42/a930db25593e0a94dc2ff7030956cbf6

A screenshot of the problem

Step 3:
Image

Step 4:
Image

Step 5:
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingunconfirmedCan't reproduce, more information needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions