refactor: remove deprecated standalone lfs-proxy binary

Addresses reviewer feedback (klaudworks): cmd/lfs-proxy/ duplicated ~30%
of the unified proxy's infrastructure (TCP listener, Kafka protocol
handling, connection management, health checks).

LFS is now exclusively a feature-flag on the unified proxy, enabled with
KAFSCALE_PROXY_LFS_ENABLED=true. The unified proxy provides partition-aware
routing (vs round-robin) and consumer group support.

Removed:
- cmd/lfs-proxy/ (5,733 lines of Go source + tests)
- deploy/docker/lfs-proxy.Dockerfile
- deploy/helm/kafscale/templates/lfs-proxy-*.yaml (6 Helm templates)
- test/e2e/lfs_proxy_*.go (e2e tests that exec'd the standalone binary)
- CI jobs: build-lfs-proxy, e2e-lfs-proxy
- Makefile targets: docker-build-lfs-proxy, test-lfs-proxy-broker

Kept:
- cmd/proxy/lfs_*.go (unified proxy LFS module)
- pkg/lfs/ (shared LFS library)
- api/lfs-proxy/openapi.yaml (API spec)
- lfs-client-sdk/ (all client SDKs)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: kamir

.github/workflows/ci.yml

@@ -57,28 +57,6 @@ jobs:
       - name: Run go test -race ./...
         run: go test -race ./...
 
-  build-lfs-proxy:
-    name: Build LFS Proxy
-    runs-on: ubuntu-latest
-    env:
-      GOCACHE: ${{ github.workspace }}/.gocache
-    steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
-
-      - uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v5
-        with:
-          go-version-file: go.mod
-          cache-dependency-path: go.sum
-
-      - name: Prepare Go build cache
-        run: mkdir -p "$GOCACHE"
-
-      - name: Build lfs-proxy
-        run: go build -o lfs-proxy ./cmd/lfs-proxy
-
-      - name: Run lfs-proxy tests
-        run: go test ./cmd/lfs-proxy/...
-
   go-coverage:
     name: Go Coverage Gate
     runs-on: ubuntu-latest
@@ -99,26 +77,6 @@ jobs:
         run: bash hack/check_coverage.sh 45
 
 
-  e2e-lfs-proxy:
-    name: LFS Proxy E2E
-    runs-on: ubuntu-latest
-    env:
-      GOCACHE: ${{ github.workspace }}/.gocache
-      KAFSCALE_E2E: "1"
-    steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
-
-      - uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v5
-        with:
-          go-version-file: go.mod
-          cache-dependency-path: go.sum
-
-      - name: Prepare Go build cache
-        run: mkdir -p "$GOCACHE"
-
-      - name: Run LFS proxy E2E tests
-        run: go test -tags=e2e ./test/e2e -run LfsProxy
-
   helm-lint:
     name: Helm Lint
     runs-on: ubuntu-latest

Makefile

@@ -13,15 +13,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-.PHONY: proto build test tidy lint generate build-sdk docker-build docker-build-e2e-client docker-build-etcd-tools docker-build-lfs-proxy docker-clean ensure-minio start-minio stop-containers release-broker-ports test-produce-consume test-produce-consume-debug test-consumer-group test-ops-api test-mcp test-multi-segment-durability test-lfs-proxy-broker test-full test-operator test-acl demo demo-platform demo-platform-bootstrap iceberg-demo kafsql-demo platform-demo help clean-kind-all
+.PHONY: proto build test tidy lint generate build-sdk docker-build docker-build-e2e-client docker-build-etcd-tools docker-clean ensure-minio start-minio stop-containers release-broker-ports test-produce-consume test-produce-consume-debug test-consumer-group test-ops-api test-mcp test-multi-segment-durability test-full test-operator test-acl demo demo-platform demo-platform-bootstrap iceberg-demo kafsql-demo platform-demo help clean-kind-all
 
 REGISTRY ?= ghcr.io/kafscale
 STAMP_DIR ?= .build
 BROKER_IMAGE ?= $(REGISTRY)/kafscale-broker:dev
 OPERATOR_IMAGE ?= $(REGISTRY)/kafscale-operator:dev
 CONSOLE_IMAGE ?= $(REGISTRY)/kafscale-console:dev
 PROXY_IMAGE ?= $(REGISTRY)/kafscale-proxy:dev
-LFS_PROXY_IMAGE ?= $(REGISTRY)/kafscale-lfs-proxy:dev
 SQL_PROCESSOR_IMAGE ?= $(REGISTRY)/kafscale-sql-processor:dev
 MCP_IMAGE ?= $(REGISTRY)/kafscale-mcp:dev
 E2E_CLIENT_IMAGE ?= $(REGISTRY)/kafscale-e2e-client:dev
@@ -149,13 +148,6 @@ $(STAMP_DIR)/proxy.image: $(PROXY_SRCS)
 	$(DOCKER_BUILD_CMD) $(DOCKER_BUILD_ARGS) -t $(PROXY_IMAGE) -f deploy/docker/proxy.Dockerfile .
 	@touch $(STAMP_DIR)/proxy.image
 
-LFS_PROXY_SRCS := $(shell find cmd/lfs-proxy pkg go.mod go.sum)
-docker-build-lfs-proxy: $(STAMP_DIR)/lfs-proxy.image ## Build LFS proxy container image
-$(STAMP_DIR)/lfs-proxy.image: $(LFS_PROXY_SRCS)
-	@mkdir -p $(STAMP_DIR)
-	$(DOCKER_BUILD_CMD) $(DOCKER_BUILD_ARGS) -t $(LFS_PROXY_IMAGE) -f deploy/docker/lfs-proxy.Dockerfile .
-	@touch $(STAMP_DIR)/lfs-proxy.image
-
 MCP_SRCS := $(shell find cmd/mcp internal/mcpserver go.mod go.sum)
 docker-build-mcp: $(STAMP_DIR)/mcp.image ## Build MCP container image
 $(STAMP_DIR)/mcp.image: $(MCP_SRCS)
@@ -295,10 +287,6 @@ test-multi-segment-durability: release-broker-ports ensure-minio ## Run multi-se
 	KAFSCALE_E2E=1 \
 	go test -tags=e2e ./test/e2e -run TestMultiSegmentRestartDurability -v
 
-test-lfs-proxy-broker: ## Run LFS proxy e2e with real broker (embedded etcd + in-memory S3).
-	KAFSCALE_E2E=1 \
-	go test -tags=e2e ./test/e2e -run TestLfsProxyBrokerE2E -v
-
 test-full: ## Run unit tests plus local + MinIO-backed e2e suites.
 	$(MAKE) test
 	$(MAKE) test-consumer-group