Skip to content

Run verifyproblem on all examples in CI #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkreitz merged 1 commit into from
May 27, 2025
Merged

Run verifyproblem on all examples in CI #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions .github/workflows/python-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["pypy3.11", "3.11"] # 3.11 is the lowest we support, since we want StrEnum
python-version: ["3.11", "3.12", "3.13"] # 3.11 is the lowest we support, since we want StrEnum
container:
image: problemtools/githubci:latest
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
Expand All @@ -26,29 +28,35 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install mypy ruff pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
sudo apt-get update
sudo apt-get install pandoc tidy ghostscript python3 texlive-fonts-recommended texlive-lang-cyrillic texlive-latex-extra texlive-plain-generic
python -m venv venv
venv/bin/python --version
Copy link
Contributor

@pehrsoderman pehrsoderman May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover debugging?

Copy link
Contributor Author

@gkreitz gkreitz May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging yes. Not quite leftover though, I felt it was sort of reasonable to leave behind (costs nothing, and may come in handy again in the future).

venv/bin/pip install mypy ruff pytest
if [ -f requirements.txt ]; then venv/bin/pip install -r requirements.txt; fi
- name: Lint with ruff
run: ruff check --output-format=github
run: venv/bin/ruff check --output-format=github
- name: Check ruff formatting
run: ruff format --check --diff
run: venv/bin/ruff format --check --diff
- name: Test with pytest
run: pytest
run: venv/bin/pytest
- name: Run mypy
run: |
mypy --non-interactive --config-file mypy.ini -p problemtools
venv/bin/mypy --non-interactive --config-file mypy.ini -p problemtools

packages: # Use a separate job to test debian packaging to speed things up (no need to test this for every python version above)
runs-on: ubuntu-latest
container:
image: problemtools/githubci:latest
steps:
- uses: actions/checkout@v4
- name: Install apt packages (for debbuild)
with:
submodules: true
- name: Build debian packages
run: |
make builddeb
- name: Install debian package
run: dpkg -i ../kattis-problemtools_*.deb
- name: Verify examples
run: |
sudo apt-get update
sudo apt-get install debhelper dh-virtualenv dpkg-dev python3-venv automake g++ make libboost-regex-dev libgmp-dev python3 git build-essential
shopt -s extglob
verifyproblem examples/!(README.md)
shell: bash
- name: Build debian packages
run: make builddeb