Skip to content

Remove generatedata #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pehrsoderman merged 2 commits into from
May 28, 2025
Merged

Remove generatedata #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd5eacc
Remove generatedata (never made it into the standard)
gkreitz May 28, 2025
a611a38
Fix pytest dropping a guess.pdf in working directory. Check PDF magic…
gkreitz May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,3 @@ follow_untyped_imports = True
install_types = True
check_untyped_defs = True
ignore_errors = False

[mypy-problemtools.generatedata]
ignore_errors = True
264 changes: 0 additions & 264 deletions problemtools/generatedata.py
View file
Open in desktop

This file was deleted.

9 changes: 4 additions & 5 deletions tests/test_latex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@ def test_pdf_render_verifyproblem():
def test_pdf_render_problem2pdf():
# Same options as typical problem2pdf usage
with tempfile.TemporaryDirectory() as temp_dir:
options = problem2pdf.get_parser().parse_args([''])
problem_path = Path(__file__).parent / '..' / 'examples' / 'guess'
options.problem = str(problem_path.resolve())
options.language = 'en'
options.quiet = True
options.dest_dir = str(temp_dir)
temp_filename = Path(temp_dir) / 'guess.pdf'
options = problem2pdf.get_parser().parse_args(['-o', str(temp_filename), '-l', 'en', '-q', str(problem_path.resolve())])
if not problem2pdf.convert(options):
assert False, 'PDF conversion failed'
with open(temp_filename, 'rb') as temp_file:
assert temp_file.read(5) == b'%PDF-', 'Output header does not look like a PDF.'