Skip to content

Error in making MasterObject #188

@SunilSimha

Description

@SunilSimha

I'm trying to combine 8 object frames into a single datacube. I'm running the version of kcwidrp that pip downloads automatically. When I run the pipeline with object_min_nframes = 8, the code fails at making a MasterObject. Specifically, this is at line 104 of MakeMasterObject.py. Here's the error message:

2025-03-10 15:05:26:DRPF:ERROR: Exception  while invoking MakeMasterObject
Traceback (most recent call last):
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/site-packages/keckdrpframework/core/framework.py", line 229, in execute
    action_output = pipeline.get_action(action_name)(action, context)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/site-packages/keckdrpframework/pipelines/base_pipeline.py", line 84, in f
    return obj.apply()
           ^^^^^^^^^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/site-packages/keckdrpframework/primitives/base_primitive.py", line 57, in apply
    self.output = self._perform()
                  ^^^^^^^^^^^^^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/site-packages/kcwidrp/primitives/MakeMasterObject.py", line 104, in _perform
    mobj_name = get_master_name(combine_list, "mobj")
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/site-packages/kcwidrp/primitives/kcwi_file_primitives.py", line 1295, in get_master_name
    return res
           ^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/bdb.py", line 100, in trace_dispatch
    return self.dispatch_line(frame)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/sunil/miniconda3/envs/kcwi/lib/python3.12/bdb.py", line 125, in dispatch_line
    if self.quitting: raise BdbQuit
                      ^^^^^^^^^^^^^
bdb.BdbQuit
2025-03-10 15:05:26:DRPF:INFO: Event failed: name object_make_master, action MakeMasterObject, arg name KB.20220128.51334.fits, recurr False

The reason appears to be that get_master_name requires a table as an input. However, combined_list is a list (defined on line 65 of MakeMasterObject.py). Perhaps the correct argument to be passed here (and also line 113 of the same file) is self.combine_list, which is the proctable. Indeed, the pipeline proceeds smoothly after making this replacement.

Please fix. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions