Allow unspecified event when creating review (#723)

* Allow unspecified `event` when creating review

Documentation for `event` in "Create a pull request review" states that "By leaving this blank, you set the review action state to `PENDING`, which means you will need to submit the pull request review when you are ready." This means that omitting `event` is perfectly legal.

* Fix review creation test case

Since we now allow `event` to be missing, adjust the test case to expect POST request to be made.

Author: mikedld

lib/Github/Api/PullRequest/Review.php

@@ -112,11 +112,7 @@ public function comments($username, $repository, $pullRequest, $id)
      */
     public function create($username, $repository, $pullRequest, array $params = [])
     {
-        if (!isset($params['event'])) {
-            throw new MissingArgumentException('event');
-        }
-
-        if (!in_array($params['event'], ['APPROVE', 'REQUEST_CHANGES', 'COMMENT'], true)) {
+        if (array_key_exists('event', $params) && !in_array($params['event'], ['APPROVE', 'REQUEST_CHANGES', 'COMMENT'], true)) {
             throw new InvalidArgumentException(sprintf('"event" must be one of ["APPROVE", "REQUEST_CHANGES", "COMMENT"] ("%s" given).', $params['event']));
         }
 

test/Github/Tests/Api/PullRequest/ReviewTest.php

@@ -212,18 +212,18 @@ public function shouldCreateReviewComment()
 
     /**
      * @test
-     * @expectedException \Github\Exception\MissingArgumentException
      */
-    public function shouldNotCreateReviewWithoutEvent()
+    public function shouldCreatePendingReviewWithoutEvent()
     {
         $data = [
             'body' => 'Nice change',
         ];
 
         $api = $this->getApiMock();
         $api
-            ->expects($this->never())
+            ->expects($this->once())
             ->method('post')
+            ->with('/repos/octocat/Hello-World/pulls/12/reviews')
         ;
 
         $api->create('octocat', 'Hello-World', 12, $data);