Skip to content

Incorrect default implementation of /app/scripts/postRender.js #1027

@chille

Description

@chille

The service does not work at all when setting up a docker container following the instructions in README.md. All requests will return a 500 Internal Server Error with the following error message logged:

The script provided doesn't set the script variable as a valid function.

This is because there is an incorrect implementation of the file /app/scripts/postRender.js. This script does not contain any code.

If I create a file with the following code:

script = function () {}

And mount it as a volume to /app/scripts/postRender.js, then everything will work as expected.

Nowhere in the documentation is there any mention that a proper postRender script is strictly required.

I see three possible solutions:

  1. The file /app/scripts/postRender.js should be removed. The server should be able to start without it. An example file should be placed somewhere else.
  2. The server should not fail if the script is empty.
  3. An empty default implementation should be made, like the code I used above.

I would suggest the first solution. But if there is any technical aspect that make this tricky, then the other two solutions would also be okay.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions