parsing kotlin instants now by default

Author: Jolanrensen

build.gradle.kts

@@ -191,9 +191,6 @@ allprojects {
     }
     tasks.withType<KotlinCompile> {
         compilerOptions {
-            // enables support for kotlin.time.Instant as kotlinx.datetime.Instant was deprecated; Issue #1350
-            // Can be removed once kotlin.time.Instant is marked "stable".
-            optIn.add("kotlin.time.ExperimentalTime")
             // can be removed once kotlin.uuid.ExperimentalUuidApi is marked "stable".
             optIn.add("kotlin.uuid.ExperimentalUuidApi")
         }

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/parse.kt

@@ -86,10 +86,13 @@ public interface GlobalParserOptions {
     public var parseExperimentalUuid: Boolean
 
     /**
-     * Whether to allow parsing to the experimental [kotlin.time.Instant] type.
-     * By default, this is false and instants are recognized as the deprecated [kotlinx.datetime.Instant] type (#1350).
+     * Whether to allow parsing to the [kotlin.time.Instant] type.
+     * This is marked "stable" from Kotlin 2.3.0+, so, by default this is `true`.
      *
-     * NOTE: Interacting with an [Instant][kotlin.time.Instant] in your code might require
+     * If false, instants are recognized as the deprecated [kotlinx.datetime.Instant] type (#1350).
+     *
+     * NOTE: If you are using an older Kotlin version,
+     * interacting with an [Instant][kotlin.time.Instant] in your code might require
      * `@`[OptIn][OptIn]`(`[ExperimentalTime][kotlin.time.ExperimentalTime]`::class)`.
      * In notebooks, add `-opt-in=kotlin.time.ExperimentalTime` to the compiler arguments.
      */
@@ -127,9 +130,11 @@ public interface GlobalParserOptions {
  *   NOTE: Interacting with a [Uuid][Uuid] in your code might require
  *   `@`[OptIn][OptIn]`(`[ExperimentalUuidApi][ExperimentalUuidApi]`::class)`.
  *   In notebooks, add `-opt-in=kotlin.uuid.ExperimentalUuidApi` to the compiler arguments.
- * @param parseExperimentalInstant whether to allow parsing to the experimental [kotlin.time.Instant] type.
- *   By default, this is false and instants are recognized as the deprecated [kotlinx.datetime.Instant] type (#1350).
- *   NOTE: Interacting with an [Instant][kotlin.time.Instant] in your code might require
+ * @param parseExperimentalInstant whether to allow parsing to the [kotlin.time.Instant] type.
+ *    This is marked "stable" from Kotlin 2.3.0+, so, by default this is `true`.
+ *    If false, instants are recognized as the deprecated [kotlinx.datetime.Instant] type (#1350).
+ *   NOTE: If you are using an older Kotlin version,
+ *   interacting with an [Instant][kotlin.time.Instant] in your code might require
  *   `@`[OptIn][OptIn]`(`[ExperimentalTime][kotlin.time.ExperimentalTime]`::class)`.
  *   In notebooks, add `-opt-in=kotlin.time.ExperimentalTime` to the compiler arguments.
  */

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/parse.kt

@@ -186,7 +186,7 @@ internal object Parsers : GlobalParserOptions {
 
         useFastDoubleParser = true
         parseExperimentalUuid = false
-        parseExperimentalInstant = false
+        parseExperimentalInstant = true
         _locale = null
         nullStrings.addAll(listOf("null", "NULL", "NA", "N/A"))
     }

dataframe-jupyter/src/test/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/DataFrameJupyterTest.kt

@@ -9,7 +9,6 @@ abstract class DataFrameJupyterTest :
         ReplProvider.forLibrariesTesting(
             libraries = setOf("dataframe", "kandy-geo", "kandy"),
             extraCompilerArguments = listOf(
-                "-Xopt-in=kotlin.time.ExperimentalTime",
                 "-Xopt-in=kotlin.uuid.ExperimentalUuidApi",
             ),
         ),

docs/StardustDocs/topics/parse.md

@@ -39,8 +39,8 @@ df.parse { age and weight }
 `parse` tries to parse every `String`/`Char` column into one of the supported types in the following order:
 * `Int`
 * `Long`
-* `Instant` (`kotlin.time`) (requires `parseExperimentalInstant = true`, available from Kotlin 2.1+.)
-* `Instant` (`kotlinx.datetime` and `java.time`)
+* `Instant` (`kotlin.time`) (requires `parseExperimentalInstant = true`, enabled by default in DataFrame 1.0.0-Beta5)
+* `Instant` (`kotlinx.datetime` and `java.time`) (requires `parseExperimentalInstant = false`)
 * `LocalDateTime` (`kotlinx.datetime` and `java.time`)
 * `LocalDate` (`kotlinx.datetime` and `java.time`)
 * `Duration` (`kotlin.time` and `java.time`)
@@ -84,9 +84,9 @@ Available parser options:
   * Enabled by global default
 * `parseExperimentalUuid: Boolean` is used to enable or disable parsing to the experimental [`kotlin.uuid.Uuid` class](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.uuid/-uuid/).
   * Disabled by global default
-* `parseExperimentalInstant: Boolean` is used to enable or disable parsing to the experimental 
+* `parseExperimentalInstant: Boolean` is used to enable or disable parsing to the 
   [`kotlin.time.Instant` class](https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.time/-instant/), available from Kotlin 2.1+. Will parse to `kotlinx.datetime.Instant` if `false`.
-  * Disabled by global default 
+  * Disabled by global default, enabled in DataFrame 1.0.0-Beta5.
 
 <!---FUN parseWithOptions-->