[lsp] Fix URI conversion on Windows

1. VSCode drive letters are lowercase
2. LSP spec allows unstable URI %-escaping

Fixes LSP-307.

GitOrigin-RevId: a030dbb9bdf7fae3bdfcc8484ec0bbeef81253e4

Author: gregsh

api.core/src/com/jetbrains/ls/api/core/util/LSUtil.kt

@@ -12,20 +12,16 @@ import com.intellij.openapi.vfs.VirtualFileManager
 import com.intellij.openapi.vfs.findPsiFile
 import com.intellij.platform.workspace.jps.entities.*
 import com.intellij.platform.workspace.storage.EntitySource
-import com.intellij.platform.workspace.storage.InternalEnvironmentName
 import com.intellij.platform.workspace.storage.MutableEntityStorage
 import com.intellij.platform.workspace.storage.entities
 import com.intellij.platform.workspace.storage.url.VirtualFileUrlManager
 import com.intellij.psi.PsiFile
-import com.intellij.workspaceModel.ide.impl.legacyBridge.sdk.SdkBridgeImpl
-import com.intellij.workspaceModel.ide.impl.legacyBridge.sdk.SdkBridgeImpl.Companion.mutableSdkMap
 import com.intellij.workspaceModel.ide.impl.legacyBridge.sdk.customName
 import com.jetbrains.ls.api.core.LSAnalysisContext
 import com.jetbrains.ls.api.core.project
 import com.jetbrains.lsp.protocol.*
 import java.nio.file.Path
 import kotlin.io.path.exists
-import kotlin.io.path.toPath
 
 val VirtualFile.uri: URI
     get() = url.intellijUriToLspUri()
@@ -155,8 +151,8 @@ fun createSdkEntity(
 
 @Suppress("DEPRECATION")
 fun workspaceFolderPaths(params: InitializeParams): List<Path> =
-    params.workspaceFolders?.map { it.uri.asJavaUri().toPath() }
-        ?: params.rootUri?.let { listOf(it.uri.asJavaUri().toPath()) }
+    params.workspaceFolders?.mapNotNull { it.uri.toPath() }
+        ?: params.rootUri?.let { listOfNotNull(it.uri.toPath()) }
         ?: params.rootPath?.let { listOf(Path.of(it)) }
         ?: emptyList()
 

api.core/src/com/jetbrains/ls/api/core/util/UriConverter.kt

@@ -3,13 +3,12 @@ package com.jetbrains.ls.api.core.util
 
 import com.intellij.openapi.util.SystemInfoRt
 import com.intellij.openapi.util.io.FileUtilRt
+import com.intellij.openapi.vfs.VfsUtilCore
 import com.jetbrains.lsp.protocol.URI
 import java.nio.file.Path
 import java.nio.file.Paths
 import kotlin.io.path.absolutePathString
 import kotlin.io.path.extension
-import kotlin.io.path.name
-import kotlin.io.path.toPath
 import java.net.URI as JavaUri
 
 /**
@@ -121,7 +120,7 @@ object UriConverter {
         path = path.removePrefix("/")
         if (SystemInfoRt.isWindows && path.length > 2 && path[1] == ':') {
             // encode `:` with `%3A` as vscode does this to have consistent uris
-           path = path[0].uppercase() + "%3A" + path.substring(2)
+            path = path[0].lowercase() + "%3A" + path.substring(2)
         }
         path = "/$path"
         return path
@@ -138,6 +137,10 @@ fun Path.toLspUri(): URI {
     return URI(uriString)
 }
 
+fun URI.toPath(): Path? {
+    val url = UriConverter.lspUriToIntellijUri(uri) ?: return null
+    return Path.of(FileUtilRt.toSystemDependentName(VfsUtilCore.urlToPath(url)))
+}
 
 /**
  * Returns the URI's scheme without scheme delimiter (`://`)

api.core/test/com/jetbrains/ls/api/core/util/UriConverterTest.kt

@@ -120,12 +120,12 @@ class UriConverterTest {
     fun `should convert IntelliJ URI to LSP URI for Windows paths`() {
         onlyOnWindows {
             testIntellijToLsp(
-                "file:///C%3A/Users/test/file.txt",
-                "file://c:/Users/test/file.txt"
+                "file:///c%3A/Users/test/file.txt",
+                "file://C:/Users/test/file.txt"
             )
 
             testIntellijToLsp(
-                "file:///D%3A/Program%20Files/App/config.xml",
+                "file:///d%3A/Program%20Files/App/config.xml",
                 "file://d:/Program Files/App/config.xml"
             )
         }
@@ -135,7 +135,7 @@ class UriConverterTest {
     fun `should convert IntelliJ URI to LSP URI for JAR files`() {
         onlyOnWindows {
             testIntellijToLsp(
-                "jar:///C%3A/libs/app.jar!/com/example/Main.class",
+                "jar:///c%3A/libs/app.jar!/com/example/Main.class",
                 "jar://C:/libs/app.jar!/com/example/Main.class"
             )
         }
@@ -163,12 +163,12 @@ class UriConverterTest {
 
         onlyOnWindows {
             testIntellijToLsp(
-                "file:///C%3A/path/with%20spaces/file.txt",
+                "file:///c%3A/path/with%20spaces/file.txt",
                 "file://c:/path/with spaces/file.txt"
             )
 
             testIntellijToLsp(
-                "file:///C%3A/path/with%23hash/file.txt",
+                "file:///c%3A/path/with%23hash/file.txt",
                 "file://c:/path/with#hash/file.txt"
             )
         }
@@ -340,12 +340,12 @@ class UriConverterTest {
         onlyOnWindows {
             run {
                 val path = Path.of("c:\\path\\to\\jar.jar")
-                assertEquals("jar:///C%3A/path/to/jar.jar!/", path.toLspUri().uri)
+                assertEquals("jar:///c%3A/path/to/jar.jar!/", path.toLspUri().uri)
             }
 
             run {
                 val path = Path.of("d:\\path\\to\\nonJar.txt")
-                assertEquals("file:///D%3A/path/to/nonJar.txt", path.toLspUri().uri)
+                assertEquals("file:///d%3A/path/to/nonJar.txt", path.toLspUri().uri)
             }
         }
     }