Revert problematic fixes

Author: dkhalanskyjb

core/common/test/ClockTimeSourceTest.kt

@@ -46,7 +46,7 @@ class ClockTimeSourceTest {
         assertEquals(1.days, mark.elapsedNow())
 
         clock.instant -= 2.days
-        assertEquals((-1).days, mark.elapsedNow())
+        assertEquals(-1.days, mark.elapsedNow())
 
         clock.instant = Instant.MAX
         assertEquals(Duration.INFINITE, mark.elapsedNow())
@@ -126,3 +126,4 @@ class ClockTimeSourceTest {
         assertEquals(clock1.now(), clock3.now())
     }
 }
+

core/common/test/DeprecatedClockTimeSourceTest.kt

@@ -43,7 +43,7 @@ class DeprecatedClockTimeSourceTest {
         assertEquals(1.days, mark.elapsedNow())
 
         clock.instant -= 2.days
-        assertEquals((-1).days, mark.elapsedNow())
+        assertEquals(-1.days, mark.elapsedNow())
 
         clock.instant = Instant.fromEpochSeconds(Long.MAX_VALUE)
         assertEquals(Duration.INFINITE, mark.elapsedNow())

core/common/test/assertions.kt

@@ -9,21 +9,27 @@ import kotlinx.datetime.DateTimeFormatException
 import kotlin.test.assertFailsWith
 import kotlin.test.fail
 
-inline fun <T> assertArithmeticFails(message: String? = null, f: () -> T) {
+@Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
+@kotlin.internal.InlineOnly
+internal inline fun <T> assertArithmeticFails(message: String? = null, f: () -> T) {
     assertFailsWith<DateTimeArithmeticException>(message) {
         val result = f()
         fail(result.toString())
     }
 }
 
-inline fun <T> assertInvalidFormat(message: String? = null, f: () -> T) {
+@Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
+@kotlin.internal.InlineOnly
+internal inline fun <T> assertInvalidFormat(message: String? = null, f: () -> T) {
     assertFailsWith<DateTimeFormatException>(message) {
         val result = f()
         fail(result.toString())
     }
 }
 
-inline fun <T> assertIllegalArgument(message: String? = null, f: () -> T) {
+@Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
+@kotlin.internal.InlineOnly
+internal inline fun <T> assertIllegalArgument(message: String? = null, f: () -> T) {
     assertFailsWith<IllegalArgumentException>(message) {
         val result = f()
         fail(result.toString())
@@ -33,4 +39,4 @@ inline fun <T> assertIllegalArgument(message: String? = null, f: () -> T) {
 /**
  * The number of iterations to perform in nondeterministic tests.
  */
-const val STRESS_TEST_ITERATIONS = 1000
+const val STRESS_TEST_ITERATIONS = 1000

core/commonKotlin/src/UtcOffset.kt

@@ -97,7 +97,8 @@ public actual class UtcOffset private constructor(public actual val totalSeconds
 @ThreadLocal
 private var utcOffsetCache: MutableMap<Int, UtcOffset> = mutableMapOf()
 
-public actual fun UtcOffset(hours: Int?, minutes: Int?, seconds: Int?): UtcOffset =
+@Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS") // for IDE quickhelp in platform-specific user sourcesets + Dokka
+public actual fun UtcOffset(hours: Int? = null, minutes: Int? = null, seconds: Int? = null): UtcOffset =
     when {
         hours != null ->
             UtcOffset.ofHoursMinutesSeconds(hours, minutes ?: 0, seconds ?: 0)

core/jvm/src/UtcOffsetJvm.kt

@@ -58,7 +58,7 @@ public actual class UtcOffset(
     private fun writeReplace(): Any = Ser(Ser.UTC_OFFSET_TAG, this)
 }
 
-@Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
+@Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS") // for IDE quickhelp in platform-specific user sourcesets + Dokka
 public actual fun UtcOffset(hours: Int? = null, minutes: Int? = null, seconds: Int? = null): UtcOffset =
     try {
         when {

integration-testing/js-without-timezones/build.gradle.kts

@@ -22,7 +22,7 @@ kotlin {
     sourceSets.all {
         val suffixIndex = name.indexOfLast { it.isUpperCase() }
         val targetName = name.substring(0, suffixIndex)
-        val suffix = name.substring(suffixIndex).lowercase(Locale.ROOT).takeIf { it != "main" }
+        val suffix = name.substring(suffixIndex).lowercase().takeIf { it != "main" }
         kotlin.srcDir("$targetName/${suffix ?: "src"}")
         resources.srcDir("$targetName/${suffix?.let { it + "Resources" } ?: "resources"}")
     }

integration-testing/serialization/build.gradle.kts

@@ -77,7 +77,7 @@ kotlin {
     sourceSets.all {
         val suffixIndex = name.indexOfLast { it.isUpperCase() }
         val targetName = name.substring(0, suffixIndex)
-        val suffix = name.substring(suffixIndex).lowercase(Locale.ROOT).takeIf { it != "main" }
+        val suffix = name.substring(suffixIndex).lowercase().takeIf { it != "main" }
         kotlin.srcDir("$targetName/${suffix ?: "src"}")
         resources.srcDir("$targetName/${suffix?.let { it + "Resources" } ?: "resources"}")
     }

timezones/full/build.gradle.kts

@@ -65,7 +65,7 @@ kotlin {
     sourceSets.all {
         val suffixIndex = name.indexOfLast { it.isUpperCase() }
         val targetName = name.substring(0, suffixIndex)
-        val suffix = name.substring(suffixIndex).lowercase(Locale.ROOT).takeIf { it != "main" }
+        val suffix = name.substring(suffixIndex).lowercase().takeIf { it != "main" }
         kotlin.srcDir("$targetName/${suffix ?: "src"}")
         resources.srcDir("$targetName/${suffix?.let { it + "Resources" } ?: "resources"}")
     }