Merge pull request #2 from LambdaTest/add-engine-info

add engine info

Author: rishabh-arya95

pkg/nodejs/packagejson/parse.go

@@ -14,6 +14,7 @@ type packageJSON struct {
 	Name                 string            `json:"name"`
 	Version              string            `json:"version"`
 	License              interface{}       `json:"license"`
+	Engines              map[string]string `json:"engines"`
 	Dependencies         map[string]string `json:"dependencies"`
 	DevDependencies      map[string]string `json:"devDependencies"`
 	OptionalDependencies map[string]string `json:"optionalDependencies"`
@@ -24,6 +25,7 @@ type Package struct {
 	Dependencies         map[string]string
 	OptionalDependencies map[string]string
 	DevDependencies      map[string]string
+	Engines              map[string]string
 }
 
 type Parser struct{}
@@ -38,12 +40,6 @@ func (p *Parser) Parse(r io.Reader) (Package, error) {
 		return Package{}, xerrors.Errorf("JSON decode error: %w", err)
 	}
 
-	// Name and version fields are optional
-	// https://docs.npmjs.com/cli/v9/configuring-npm/package-json#name
-	if pkgJSON.Name == "" || pkgJSON.Version == "" {
-		return Package{}, nil
-	}
-
 	return Package{
 		Library: types.Library{
 			ID:      utils.PackageID(pkgJSON.Name, pkgJSON.Version),
@@ -54,6 +50,7 @@ func (p *Parser) Parse(r io.Reader) (Package, error) {
 		Dependencies:         pkgJSON.Dependencies,
 		OptionalDependencies: pkgJSON.OptionalDependencies,
 		DevDependencies:      pkgJSON.DevDependencies,
+		Engines:              pkgJSON.Engines,
 	}, nil
 }
 

pkg/nodejs/packagejson/parse_test.go

@@ -100,7 +100,12 @@ func TestParse(t *testing.T) {
 		{
 			name:      "happy path - version doesn't exist",
 			inputFile: "testdata/without_version_package.json",
-			want:      packagejson.Package{},
+			want: packagejson.Package{
+				Library: types.Library{
+					ID:   "angular@",
+					Name: "angular",
+				},
+			},
 		},
 		{
 			name:      "sad path",
@@ -112,6 +117,24 @@ func TestParse(t *testing.T) {
 			// npm ls | grep -E -o "\S+@\S+" | awk -F@ 'NR>0 {printf("{\""$1"\", \""$2"\"},\n")}'
 			wantErr: "JSON decode error",
 		},
+		{
+			name:      "engines",
+			inputFile: "testdata/engines_package.json",
+			want: packagejson.Package{
+				Library: types.Library{
+					ID:      "lodash@5.0.0",
+					Name:    "lodash",
+					Version: "5.0.0",
+					License: "MIT",
+				},
+				DevDependencies: map[string]string{
+					"mocha": "^5.2.0", "eslint": "^7.16.0",
+					"eslint-plugin-import": "^2.22.1",
+					"lodash":               "4.17.20", "esm": "^3.2.25",
+				},
+				Engines: map[string]string{"node": ">=4.0.0"},
+			},
+		},
 	}
 
 	for _, v := range vectors {

pkg/nodejs/packagejson/testdata/engines_package.json

@@ -0,0 +1,23 @@
+{
+    "name": "lodash",
+    "version": "5.0.0",
+    "license": "MIT",
+    "private": true,
+    "main": "lodash.js",
+    "engines": {
+      "node": ">=4.0.0"
+    },
+    "sideEffects": false,
+    "scripts": {
+      "style": "eslint *.js .internal/**/*.js",
+      "test": "mocha -r esm test/*.test.js",
+      "validate": "npm run style && npm run test"
+    },
+    "devDependencies": {
+      "mocha": "^5.2.0",
+      "eslint": "^7.16.0",
+      "eslint-plugin-import": "^2.22.1",
+      "lodash": "4.17.20",
+      "esm": "^3.2.25"
+    }
+  }