Commit 648a731
Labeled field updates (#595)
* Allows LabeledField to accept optional as prop and updates Checkbox+Radio Group
* Uses css to visually hide label if set to false for Checkbox+Radio Groups to preserve html semantics
* Displays required indicator and hint if provided
* Updates dropdown-checkbox-group to match the same semantics as regular checkbox-group
* Remove dropdown-checkbox-group component
* Add Dropdown in storybook
* Remove unused css files
* Update styling
* Define checkbox group container outside of component
* Remove test suite re: missing legend
* Set group role on labeled field and simplify classname logic
* Move dropdown test suite into checkbox-group test file
* Update comment
* Update version
* Update helper comment
* Undo defining variable outside
* use prepare for yarn run build
* update comments
* explicitly set true on useDropdown
* update select component to use fieldset and legend
* update tests to use test id for labeled field component
* undo updates in select
* rename prop
* use option.value for key
* update test
* add dropdown checkboxgroup tests
* add test units for updated legend
* rename prop rename
* update proptype
* add migration guide
* use shorthand assignment
* add & update migration guide
* use describe
* conditionally set field-wrapper class name and remove data-testid
* add visually hidden class assertion
* replace example in test to use grouped elements
* update param sentence
* be explicit with allowed proptypes for wrapper element
* fix typo
* use markup for components
* pass in is-active conditional classname on higher level
* update dropdown select so the labels populate
* Add a section about dropdown selection changes in migration guide
* Update comments
* wrap tests under describe
* Use the correct labels for dropdown test
* Pass in id for checkbox label that matches input id
* Use labels for safe guard check
---------
Co-authored-by: Ji Hye Park <jihyepark@Jis-MacBook-Pro.local>
Co-authored-by: Ji Hye Park <jihyepark@jis-macbook-pro.attlocal.net>
Co-authored-by: Ji Hye Park <jihyepark@Jis-MacBook-Pro.AN-700-AP-I-AC>
Co-authored-by: Conor <conor@launchpadlab.com>1 parent 9c27a1d commit 648a731
File tree
28 files changed
+1160
-1236
lines changed- .storybook/styles
- components
- pages
- migration-guides
- src/forms
- helpers
- inputs
- labels
- stories/forms/inputs
- test/forms
- inputs
- labels
28 files changed
+1160
-1236
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
74 | 79 | | |
75 | 80 | | |
| |||
404 | 409 | | |
405 | 410 | | |
406 | 411 | | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | 412 | | |
431 | 413 | | |
432 | 414 | | |
| |||
571 | 553 | | |
572 | 554 | | |
573 | 555 | | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
| 556 | + | |
| 557 | + | |
581 | 558 | | |
582 | 559 | | |
583 | 560 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
0 commit comments