Please update for PHP80

[hitched97]

Does not build as-is for php80. Removing all occurrences of TSRMLS_C, TSRMLS_CC, TSRMLS_DC, and TSRMLS_FETCH allows it to compile, but then every invocation of PHP spews a 'Missing arginfo' message for every defined radius function.

[Jan-E]

Even if it builds, the arginfo definitions are missing:

Warning: Missing arginfo for radius_auth_open()
Warning: Missing arginfo for radius_acct_open()
Warning: Missing arginfo for radius_close()
Warning: Missing arginfo for radius_strerror()
Warning: Missing arginfo for radius_config()
Warning: Missing arginfo for radius_add_server()
Warning: Missing arginfo for radius_create_request()
Warning: Missing arginfo for radius_put_string()
Warning: Missing arginfo for radius_put_int()
Warning: Missing arginfo for radius_put_attr()
Warning: Missing arginfo for radius_put_addr()
Warning: Missing arginfo for radius_put_vendor_string()
Warning: Missing arginfo for radius_put_vendor_int()
Warning: Missing arginfo for radius_put_vendor_attr()
Warning: Missing arginfo for radius_put_vendor_addr()
Warning: Missing arginfo for radius_send_request()
Warning: Missing arginfo for radius_get_attr()
Warning: Missing arginfo for radius_get_tagged_attr_data()
Warning: Missing arginfo for radius_get_tagged_attr_tag()
Warning: Missing arginfo for radius_get_vendor_attr()
Warning: Missing arginfo for radius_cvt_addr()
Warning: Missing arginfo for radius_cvt_int()
Warning: Missing arginfo for radius_cvt_string()
Warning: Missing arginfo for radius_salt_encrypt_attr()
Warning: Missing arginfo for radius_request_authenticator()
Warning: Missing arginfo for radius_server_secret()
Warning: Missing arginfo for radius_demangle()
Warning: Missing arginfo for radius_demangle_mppe_key()

[jkroonza]

I note there are two pull requests open for this, but neither has been merged yet, how can we make progress here and is there anything we can do to help? Never worked with a php/pecl module yet, so if there is a guide on how to approach this, or pointers, I'd be happy to see if we can dedicate resources on this. Lots of info out there on how to migrate PHP code itself ... but I can't find anything on the modules themselves. Happy to assist with both code and testing.

[alexmontoanelli]

HI, try this.

Get the source of this package ready for php 8
https://github.com/UNETVALE/php-radius/archive/refs/heads/master.zip

Unpack and build with php tools for php 8 or php.81.
unzip master.zip && cd php-radius-master && phpize && ./configure && make && make install

Load the extension on your own php.ini file.

[Jan-E]

Which is the archive taken from https://github.com/UNETVALE/php-radius
It is just the same as this repo would be after merging #6
But #9 is probably a better PR.

[jkroonza]

OK, neither #6 or #9 is working for me.

Trying to apply directly on top of the archive at https://pecl.php.net/get/radius-1.4.0b1.tgz

#6 states as the first commit that it's importing that archive, so skipping over the first I get similar compile errors to #9.

#9 doesn't actually fix PHP8 compatibility and after applying it the build still only works for PHP7.4, not for PHP8.0 or PHP8.1.

Unfortunately I'm not permitted to just grab and use the archives as proposed.

[mbretter]

I have just merged #9, it would be great if someone can do some testing and file some PRs if there are issues.

I have initially created this package, but have not worked on this more almost 20yrs, though I have not the permissions to transfer the ownership, I can merge PRs.

[jkroonza]

The news is not good. At least not for php8.1.

make.log
config.log
configure.log

config.log is generated by ./configure, configure.log is the CLI output from ./configure.

Similar failures for php8.0.

[maticomba]

The same errors as @jkroonza reported in Ubuntu 22.04.1 LTS.

# php -v
PHP 8.1.2-1ubuntu2.9 (cli) (built: Oct 19 2022 14:58:09) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.2, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.2-1ubuntu2.9, Copyright (c), by Zend Technologies

[StephenWall]

I have a working patch for PHP 8.0.12, I will see about getting corporate permission to provide it here.

[StephenWall]

Here's my php 8 patch

php-radius.diff.gz

[jkroonza]

And the one Gentoo ended up using, which is what was merged (as I understand) + a few other changes to work around the errors I encountered.

1.4.0-php8.patch.gz

This applies on top of the archive from pecl for 1.4.0. I can confirm it works for 8.0 and 8.1, and according to the person that wrote it for 8.2 as well, but I'm not in a position to test that.

DISCLAIMER: I did not write this, the commit entry that added this into Gentoo reads as follows:

commit 6a43f0c27da369f2428587735b2cf6f46c8c49a3
Author: Brian Evans <grknight@gentoo.org>
Date:   Tue Dec 13 11:00:22 2022 -0500

    dev-php/pecl-radius: Patch 8.0 support from upstream repo
    
    Adds in additional support missing upstream
    
    Closes: https://bugs.gentoo.org/881465
    Signed-off-by: Brian Evans <grknight@gentoo.org>

[mbretter]

I have applied the patch above to a new php8 branch.
I had to go 2 commits back to be able to apply the patchset:
34cb80d45482756d8400e34dc148c7686ed5d58d

Could you please check if the php8 branch has a working codebase?

[alexmontoanelli]

I was unable to build foi master too.

Using my own repo with my fixes, was solid good.

https://github.com/alexmontoanelli/php-radius

[StephenWall]

My patch applies to 1.4.0b1 available from pecl.php.net, as this is what FreeBSD includes in their ports tree. Sorry, I'm not sure how that relates to the master branch here.

[StephenWall]

Oh, also, FreeBSD distributes a patch that removes all the TSRMLS stuff, so I did not address that in my patch.