Skip to content

Commit f63bad1

Browse files
authored
fix: address CodeRabbit review findings (#204)
- Remove contradictory workflow_dispatch example from reusable-workflows rules - Remove stale {{major}}.{{minor}} tag from build-workflow docs - Fix linear backoff to true exponential (2**i) in gitops-update retry loop
1 parent 6059c0f commit f63bad1

3 files changed

Lines changed: 1 addition & 11 deletions

File tree

.cursor/rules/reusable-workflows.mdc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,6 @@ on:
146146
secrets:
147147
DEPLOY_TOKEN:
148148
required: true
149-
workflow_dispatch:
150-
inputs:
151-
environment:
152-
required: true
153-
type: string
154-
dry_run:
155-
description: Preview changes without applying them
156-
type: boolean
157-
default: false
158149
```
159150

160151
The two modes have opposite goals — design them accordingly:

.github/workflows/gitops-update.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ jobs:
458458
exit 1
459459
fi
460460
461-
BACKOFF=$((i * 2))
461+
BACKOFF=$((2 ** i))
462462
echo "Push failed (attempt $i/$MAX_RETRIES), rebasing and retrying in ${BACKOFF}s..."
463463
sleep "$BACKOFF"
464464
git pull --rebase origin main

docs/build-workflow.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ Generated tags based on semantic versioning:
139139
| Tag Pattern | Example | When Applied |
140140
|-------------|---------|--------------|
141141
| `{{version}}` | `1.0.0-beta.1` | Always |
142-
| `{{major}}.{{minor}}` | `1.0` | Always |
143142
| `{{major}}` | `1` | Release tags only |
144143

145144
## Monorepo Change Detection

0 commit comments

Comments
 (0)