fix: fix FormPacketHelper

Dofes · Dofes · commit 09f617a52232 · 2024-04-07T01:12:01.000+08:00
diff --git a/src/legacy/legacyapi/form/FormPacketHelper.cpp b/src/legacy/legacyapi/form/FormPacketHelper.cpp
@@ -85,6 +85,7 @@ void HandleFormPacket(Player* player, unsigned formId, const std::string& data)
         if (form->callback) form->callback(player, chosen);
         // Button Callback
         if (chosen >= 0) {
+            if (chosen >= form->elements.size()) return;
             auto button = dynamic_pointer_cast<Button>(form->elements[chosen]);
             if (button->callback) button->callback(player);
         }

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ void HandleFormPacket(Player* player, unsigned formId, const std::string& data)`
`85`	`85`	`if (form->callback) form->callback(player, chosen);`
`86`	`86`	`// Button Callback`
`87`	`87`	`if (chosen >= 0) {`
	`88`	`+ if (chosen >= form->elements.size()) return;`
`88`	`89`	`auto button = dynamic_pointer_cast<Button>(form->elements[chosen]);`
`89`	`90`	`if (button->callback) button->callback(player);`
`90`	`91`	`}`